Date: Fri, 21 Oct 2011 05:30:46 +0000 From: Nali Toja <nalitoja@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/161856: [patch] emulators/qemu-devel: respect STRIP Message-ID: <86sjmmap2x.fsf@gmail.com> Resent-Message-ID: <201110210540.p9L5eAFR088301@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 161856
>Category: ports
>Synopsis: [patch] emulators/qemu-devel: respect STRIP
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Oct 21 05:40:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Nali Toja
>Release: FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Do not strip uncoditionally, it makes system-wide profiling more cumbersome.
>How-To-Repeat:
$ make install STRIP=
$ qemu &
# qemu itself + libs/kernel
$ pmcstat -t qemu -P instructions -T
# system-wide with lots of noise from other apps
$ pmcstat -S instructions -T
>Fix:
--- strip.diff begins here ---
Index: emulators/qemu-devel/Makefile
===================================================================
RCS file: /a/.csup/ports/emulators/qemu-devel/Makefile,v
retrieving revision 1.128
diff -u -p -r1.128 Makefile
--- emulators/qemu-devel/Makefile 13 Oct 2011 19:08:30 -0000 1.128
+++ emulators/qemu-devel/Makefile 20 Oct 2011 01:30:58 -0000
@@ -145,6 +145,10 @@ MAKE_ARGS+= NOPORTDOCS=${NOPORTDOCS}
BUILD_DEPENDS+= texi2html:${PORTSDIR}/textproc/texi2html
.endif
+.if !defined(STRIP) || ${STRIP} == ""
+CONFIGURE_ARGS+=--disable-strip
+.endif
+
.if ${ARCH} == "amd64"
MAKE_ARGS+= ARCH=x86_64
.endif
--- strip.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86sjmmap2x.fsf>