From owner-svn-src-all@FreeBSD.ORG Sat Jan 19 00:05:26 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 01918F6F; Sat, 19 Jan 2013 00:05:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id D29A4EF5; Sat, 19 Jan 2013 00:05:25 +0000 (UTC) Received: from John-Baldwins-MacBook-Air.local (c-68-39-198-164.hsd1.de.comcast.net [68.39.198.164]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1229CB94C; Fri, 18 Jan 2013 19:05:25 -0500 (EST) Message-ID: <50F9E354.1070709@FreeBSD.org> Date: Fri, 18 Jan 2013 19:05:40 -0500 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Andrew Turner Subject: Re: svn commit: r245610 - head/bin/ps References: <201301181824.r0IIOfxd094865@svn.freebsd.org> <20130119112953.7a9aa66e@fubar.geek.nz> In-Reply-To: <20130119112953.7a9aa66e@fubar.geek.nz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 18 Jan 2013 19:05:25 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2013 00:05:26 -0000 On 1/18/13 5:29 PM, Andrew Turner wrote: > On Fri, 18 Jan 2013 18:24:41 +0000 (UTC) > John Baldwin wrote: > >> Author: jhb >> Date: Fri Jan 18 18:24:40 2013 >> New Revision: 245610 >> URL: http://svnweb.freebsd.org/changeset/base/245610 >> >> Log: >> Include the thread name along with the command name when displaying >> the command name of a thread from a multi-threaded process that >> doesn't have an available argument list (such as kernel processes) >> and threads display is enabled via -H. >> >> Reviewed by: alfred, delphij, eric@vangyzen.net >> MFC after: 1 week > > This breaks usr.bin/w as it includes bin/ps/fmt.c in it's build but > doesn't have the showthreads variable defined. Ugh. It requires a bit more fixing than that even since w uses fmt_argv() directly (and it had a stale prototype to boot). I have a fix to get both ps and w to build but am waiting for a full world to finish first in case some other place (ab)uses this. -- John Baldwin