From owner-svn-src-all@freebsd.org Fri Feb 15 03:09:07 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0EA5B14EC91F for ; Fri, 15 Feb 2019 03:09:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 99C4E72A65 for ; Fri, 15 Feb 2019 03:09:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id y4so9377803qtc.10 for ; Thu, 14 Feb 2019 19:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w/Tmz/QJpfg6fAACm4QLFtGuOColTFMtPSlihxUx7cU=; b=nu9SP9zVniDPn6zrozIvKWqJT3APm7XgrGdAo0rt32ndCzCIVJDqQmwYDSGZgHOeFZ AU3IgZBOmYgGFxlYh5HCO76Gz7gD5f0pTMUq+JaJhUsR8M5qDtMv7YmXRI/X1FCAfeUz +BbvUYyDQvpQ6LPPLDAtb8p3TjBS3HErh4ww8KZwlPZRSJm5nRW3FbNOV5N5/KoQQVkY +/lEN1GTRiz5SYjq8thTeBtxQk+yKSg/OYBd1EkRd3Zk4ExORsODnod41/WcN+4eT4xq MGqIrpj2Qpbj81GU8oR1BCXp7xs/u7ROIk2zeQ+JhkO7fenkIVktV4bPUtG/zLGnv9mH H7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w/Tmz/QJpfg6fAACm4QLFtGuOColTFMtPSlihxUx7cU=; b=CjEFlEw6ykUzni5fOhcOuAX8+AM+qy5UTomx/uh9zYIfbRO9ftzFW/NZXc+dKIX64/ zEEIzy5obRV8WTMiT0ILsE1WPL2dfQt3rap7ZRA6Ak+LNtbHK2n4LsGy7cOZTJqExWPD DHwKOlqRDba4Nb8V0FdyIbClnzHMjL++6YhSta+ztnahCotTzjrvTZBEWGpTJApM13jG 8vckjoV+K4k3GCl3gdzvx/M2Kmyg97VDKIT0ULPzbAeM2Lf9Nra/SVjH2d2Vm95EAJop 4mUO0BK4bhck2zI9fCG0scr79si457+7zSR9wffpZAU+bKm40tESmsK8nv+7M6h6pkjG /Npw== X-Gm-Message-State: AHQUAuZY14Yl48a094S7B6TY2rEYaCh9hduy5IiafydAhwbwvRoBFo64 8XcV1YVA8VNSX2O0Sca6CRjnYP8E1F+sHXce2K4ziA== X-Google-Smtp-Source: AHgI3IaUL1D47xTEAgGrXjv6dcWROpK3F9iDbkbdek/vUJKuq1RiVgTUapmo20HAwWUSqD5dF2n2ikUzl89CcFwUBgs= X-Received: by 2002:aed:3964:: with SMTP id l91mr5837204qte.33.1550200145932; Thu, 14 Feb 2019 19:09:05 -0800 (PST) MIME-Version: 1.0 References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 14 Feb 2019 20:08:53 -0700 Message-ID: Subject: Re: svn commit: r344129 - head To: "Rodney W. Grimes" Cc: Mark Johnston , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 99C4E72A65 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 03:09:07 -0000 On Thu, Feb 14, 2019, 1:42 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net wrote: > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > > > You sited a differential, but not give any attribution > > > > to the external source :-( > > > > > > > > > > The differential review has that information. > > > > External contributors should be recognized by having their names appear > > in the commit logs. > > We even bother to put a special line in the commit template > for this. Further it has been standard operating procedure > for at least as long as I have been back that submitters > are infact recognized in commit messages. > > You have, again, summarily dismissed valid feedback. > The problem is that was a trivial commit. And you offered not one, but two complaints about adding an 'e' to the updating file. That's what pissed me off. It's advice that might be correct, but was so far over the top, in public, for such a trivial commit. That's why I got mad: it added no value and seemed nit picky and pretty. So I lost it. I shouldn't have, but I did. I'm sorry for my cool. Warner >