From owner-freebsd-net@FreeBSD.ORG  Fri Jan 10 10:31:56 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E30D5854;
 Fri, 10 Jan 2014 10:31:56 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D1931E1A;
 Fri, 10 Jan 2014 10:31:55 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id s0AAVeoQ033502
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 10 Jan 2014 14:31:40 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id s0AAVeW0033501;
 Fri, 10 Jan 2014 14:31:40 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 10 Jan 2014 14:31:40 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Luigi Rizzo <rizzo@iet.unipi.it>
Subject: Re: unused in_cksum_update() ?
Message-ID: <20140110103140.GD73147@FreeBSD.org>
References: <20140109192114.GA49934@onelab2.iet.unipi.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140109192114.GA49934@onelab2.iet.unipi.it>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: current@freebsd.org, net@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jan 2014 10:31:57 -0000

On Thu, Jan 09, 2014 at 08:21:14PM +0100, Luigi Rizzo wrote:
L> a lot of arch-specific headers (sys/${ARCH}/include/in_cksum.h)
L> have a lengthy definition for
L> 
L> 	in_cksum_update(struct ip *ip)
L> 
L> which seems completely unused in our source tree.
L> Time to remove it perhaps ?
L> 
L> grep cannot find any use at least since stable/8

I'd prefer not to hurry with its removal. Might be that pf will use it.
Since it lives in a header file, it doesn't add a single bit to kernel
size.

-- 
Totus tuus, Glebius.