From owner-svn-src-all@freebsd.org  Thu Oct 25 12:27:18 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1F7C10744DC;
 Thu, 25 Oct 2018 12:27:17 +0000 (UTC)
 (envelope-from hselasky@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mxrelay.nyi.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 8C8BD7FDA8;
 Thu, 25 Oct 2018 12:27:17 +0000 (UTC)
 (envelope-from hselasky@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 69D5911C61;
 Thu, 25 Oct 2018 12:27:17 +0000 (UTC)
 (envelope-from hselasky@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w9PCRHvk080420;
 Thu, 25 Oct 2018 12:27:17 GMT (envelope-from hselasky@FreeBSD.org)
Received: (from hselasky@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id w9PCRHel080419;
 Thu, 25 Oct 2018 12:27:17 GMT (envelope-from hselasky@FreeBSD.org)
Message-Id: <201810251227.w9PCRHel080419@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: hselasky set sender to
 hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
Date: Thu, 25 Oct 2018 12:27:17 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject: svn commit: r339708 - stable/12/sys/dev/sound/midi
X-SVN-Group: stable-12
X-SVN-Commit-Author: hselasky
X-SVN-Commit-Paths: stable/12/sys/dev/sound/midi
X-SVN-Commit-Revision: 339708
X-SVN-Commit-Repository: base
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 12:27:18 -0000

Author: hselasky
Date: Thu Oct 25 12:27:16 2018
New Revision: 339708
URL: https://svnweb.freebsd.org/changeset/base/339708

Log:
  MFC r339581:
  Fix off-by-one which can lead to panics.
  
  Found by:		Peter Holm <peter@holm.cc>
  Approved by:		re (kib)
  Sponsored by:		Mellanox Technologies

Modified:
  stable/12/sys/dev/sound/midi/sequencer.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/sound/midi/sequencer.c
==============================================================================
--- stable/12/sys/dev/sound/midi/sequencer.c	Thu Oct 25 12:13:13 2018	(r339707)
+++ stable/12/sys/dev/sound/midi/sequencer.c	Thu Oct 25 12:27:16 2018	(r339708)
@@ -730,7 +730,7 @@ static int
 seq_fetch_mid(struct seq_softc *scp, int unit, kobj_t *md)
 {
 
-	if (unit > scp->midi_number || unit < 0)
+	if (unit >= scp->midi_number || unit < 0)
 		return EINVAL;
 
 	*md = scp->midis[unit];