From owner-cvs-all  Sat Jan 26 11:20:17 2002
Delivered-To: cvs-all@freebsd.org
Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id 13D9037B423; Sat, 26 Jan 2002 11:20:08 -0800 (PST)
Received: from InterJet.elischer.org ([12.232.206.8])
          by rwcrmhc51.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020126192008.GPNU26243.rwcrmhc51.attbi.com@InterJet.elischer.org>;
          Sat, 26 Jan 2002 19:20:08 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA37527;
	Sat, 26 Jan 2002 11:13:03 -0800 (PST)
Date: Sat, 26 Jan 2002 11:13:01 -0800 (PST)
From: Julian Elischer <julian@elischer.org>
To: David Malone <dwmalone@maths.tcd.ie>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm.h 
In-Reply-To: <200201261252.aa17054@salmon.maths.tcd.ie>
Message-ID: <Pine.BSF.4.21.0201261112440.37522-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

All in-kernel prototypes should be invisible to userland.


On Sat, 26 Jan 2002, David Malone wrote:

> > In the kernel it is usual to have parameter names in prototypes 
> > (it was in style) It tends to keep people using standard names for certain
> > things...
> 
> OK, but I think something in userland sees this declaration and gcc
> whines about it. I might have made the change originally when I was
> playing with WARNS and gcc3. Should this declaration be protected
> by a #ifdef _KERNEL?
> 
> I can go an dig up what produced the warning if you think that I
> would be better fixing it some other way.
> 
> (Also, the parameter name was "kmi" and the line before in vm.h
> says "extern struct kva_md_info kmi;", so the parameter would always
> be shadowing a global variable. I guess that wouldn't have been
> ideal.)
> 
> 	David.
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message