Date: Wed, 25 Mar 2009 23:40:04 GMT From: Katsuji ISHIKAWA <katsuji.ishikawa@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/133076: [maintainer-update] lang/mosh update 0.0.7_1 Message-ID: <200903252340.n2PNe4gU020125@www.freebsd.org> Resent-Message-ID: <200903252350.n2PNo2kT073740@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133076
>Category: ports
>Synopsis: [maintainer-update] lang/mosh update 0.0.7_1
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Wed Mar 25 23:50:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Katsuji ISHIKAWA
>Release: 7.1-RELEASE
>Organization:
>Environment:
FreeBSD seven.localdomain 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
In mosh-0.0.7, I did not test patch enough..
So patch-TextualInputPort.cpp makes mosh's binary bad.
solution:
Remove patch-file (patch-TextualInputPort.cpp).
And set ONLY_FOR_ARCHS= i386 (yes, only i386).
>How-To-Repeat:
# portinstall lang/mosh
# mosh
i.e)
[katsuji@seven ~]$ mosh
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_S_construct NULL not valid
Abort trap: 6 (core dumped)
-- I tested on i386 and amd64.
>Fix:
Patch attached with submission follows:
diff -uBbr /usr/ports/lang/mosh/Makefile ./Makefile
--- /usr/ports/lang/mosh/Makefile 2009-03-18 13:42:17.000000000 +0900
+++ ./Makefile 2009-03-26 08:23:07.000000000 +0900
@@ -7,6 +7,7 @@
PORTNAME= mosh
PORTVERSION= 0.0.7
+PORTREVISION= 1
CATEGORIES= lang
MASTER_SITES= ${MASTER_SITE_GOOGLE_CODE}
@@ -43,8 +44,6 @@
.include <bsd.port.pre.mk>
-.if ${ARCH} == "sparc64"
-BROKEN= Does not compile on sparc64
-.endif
+ONLY_FOR_ARCHS= i386
.include <bsd.port.post.mk>
diff -uBbr /usr/ports/lang/mosh/files/patch-TextualInputPort.cpp ./files/patch-TextualInputPort.cpp
--- /usr/ports/lang/mosh/files/patch-TextualInputPort.cpp 2009-03-08 00:29:45.000000000 +0900
+++ ./files/patch-TextualInputPort.cpp 2009-03-26 07:52:57.000000000 +0900
@@ -1,11 +1 @@
---- TextualInputPort.cpp.orig 2008-10-30 10:15:23.000000000 +0300
-+++ TextualInputPort.cpp 2009-03-02 22:01:49.000000000 +0300
-@@ -52,7 +52,7 @@
- TextualInputPort::TextualInputPort(BinaryInputPort* port, Transcoder* coder) : codec_(coder->codec()),
- port_(port),
- coder_(coder),
-- buffer_(NULL),
-+ buffer_((const ucs4char*)NULL),
- line_(1),
- error_(Object::Nil),
- scanner_(new Scanner)
+
Only in .: mosh.core
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903252340.n2PNe4gU020125>