Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Nov 2015 00:05:04 -0800
From:      NGie Cooper <yaneurabeya@gmail.com>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org
Subject:   Re: svn commit: r290263 - projects/collation/contrib/netbsd-tests/lib/libc/locale
Message-ID:  <2B614865-4775-4DF2-8EF7-D820E114F811@gmail.com>
In-Reply-To: <201511020759.tA27xHLU027275@repo.freebsd.org>
References:  <201511020759.tA27xHLU027275@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On Nov 1, 2015, at 23:59, Baptiste Daroussin <bapt@FreeBSD.org> wrote:
>=20
> Author: bapt
> Date: Mon Nov  2 07:59:17 2015
> New Revision: 290263
> URL: https://svnweb.freebsd.org/changeset/base/290263
>=20
> Log:
>  Fix regression test on multibytes
>=20
>  0x07FF and 0x0800 are valid multibyte characters:
>  'DOUBLE QUESTION MARK' and 'QUESTION EXCLAMATION MARK'
>=20
> Modified:
>  projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
>=20
> Modified: =
projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- =
projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c	=
Mon Nov  2 07:46:47 2015	(r290262)
> +++ =
projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c	=
Mon Nov  2 07:59:17 2015	(r290263)
> @@ -87,7 +87,7 @@ static struct test {
> 		0x5B, 0x01, 0x7F, 0x5D, 0x5B, 0x80, 0x07FF, 0x5D, 0x5B, =
0x0800,
> 		0xFFFF, 0x5D, 0x5B, 0x10000, 0x10FFFF, 0x5D, 0x0A
> 	},
> -	{	 1, -1, -1,  1,  1, -1, -1,  1,  1, -1, -1,  1,  1, -1, =
-1,
> +	{	 1, -1, -1,  1,  1, -1, 1,  1,  1, 1, -1,  1,  1, -1, =
-1,
> 		 1,  1, -1, -1,  1,  1, -1, -1,  1, -1

Please file an upstream PR for this (and any other failures you find) =
and if possible CC me.

I=E2=80=99ve been adding...

#ifdef __FreeBSD__
/* FreeBSD-specific fix */
#else
/* Old code from NetBSD */
#endif

=E2=80=A6 to track what needs to be upstreamed.

Thanks!
-NGie=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2B614865-4775-4DF2-8EF7-D820E114F811>