Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 May 2005 09:12:52 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Pav Lucistnik <pav@oook.cz>
Cc:        gnome@freebsd.org
Subject:   Re: seeking approval to update x11-toolkits/scintilla port
Message-ID:  <20050506091251.GA2872@FreeBSD.org>
In-Reply-To: <20050506091010.GA2266@FreeBSD.org>
References:  <20050506084512.GB98288@FreeBSD.org> <1115369830.746.4.camel@pav.hide.vol.cz> <20050506091010.GA2266@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 06, 2005 at 09:10:10AM +0000, Alexey Dokuchaev wrote:
> On Fri, May 06, 2005 at 10:57:10AM +0200, Pav Lucistnik wrote:
> > Alexey Dokuchaev p??e v p? 06. 05. 2005 v 08:45 +0000:
> > 
> > > - Adjust Makefile header
> > 
> > Not needed, IMHO
> > 
> > > - Depend on Gtk2 by default
> > 
> > Will this break qscintilla and other consumers, by chance?
> 
> I'll test some of them found in our tree, thanks for reminder.
> 
> > 
> > > @@ -23,17 +23,19 @@
> > >  USE_GMAKE=	yes
> > >  MAKEFILE=	makefile
> > >  INSTALLS_SHLIB=	yes
> > > +WANT_GNOME=	yes
> > 
> > Why WANT_GNOME ?
> 
> I also thought that it's not needed, but oftherwise it complains:
> 
> "/usr/ports/Mk/bsd.gnome.mk", line 598: Malformed conditional (${_USE_GNOME_ALL:Mgtk20}=="")
> "/usr/ports/Mk/bsd.port.mk", line 5144: if-less endif
> make: fatal errors encountered -- cannot continue

It is probably because of .include <bsd.port.pre.mk> being before USE_GNOME knobs,
but I have not tested this.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050506091251.GA2872>