From owner-cvs-all@FreeBSD.ORG Thu Jan 13 14:47:19 2005 Return-Path: <owner-cvs-all@FreeBSD.ORG> Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D65F16A4CE; Thu, 13 Jan 2005 14:47:19 +0000 (GMT) Received: from gw.Awfulhak.org (awfulhak.demon.co.uk [80.177.173.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C30143D45; Thu, 13 Jan 2005 14:47:18 +0000 (GMT) (envelope-from brian@FreeBSD.org) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.13.1/8.13.1) with ESMTP id j0DElEN6084574; Thu, 13 Jan 2005 14:47:14 GMT (envelope-from brian@FreeBSD.org) Date: Thu, 13 Jan 2005 14:47:13 +0000 From: Brian Somers <brian@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Message-ID: <20050113144713.563dcb27@dev.lan.Awfulhak.org> In-Reply-To: <Pine.NEB.3.96L.1050112175118.47006B-100000@fledge.watson.org> References: <200501121242.j0CCgldA068546@repoman.freebsd.org> <Pine.NEB.3.96L.1050112175118.47006B-100000@fledge.watson.org> X-Mailer: Sylpheed-Claws 0.9.13 (GTK+ 1.2.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.0.1 X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on gw.lan.Awfulhak.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_diskless.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-all> List-Post: <mailto:cvs-all@freebsd.org> List-Help: <mailto:cvs-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 13 Jan 2005 14:47:19 -0000 On Wed, 12 Jan 2005 17:51:56 +0000 (GMT), Robert Watson <rwatson@FreeBSD.org> wrote: > > On Wed, 12 Jan 2005, Brian Somers wrote: > > > brian 2005-01-12 12:42:46 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/nfsclient nfs_diskless.c > > Log: > > Include opt_bootp.h for BOOTP_NFSROOT > > > > PR: 73183 > > Submitted by: Darrin Smith sdar at salseast dot org > > MFC after: 7 days > > I saw this PR but decided not to pick it up because I didn't immediately > have time to test the impact on PXEbooting GENERIC kernels with NFS roots? > Have you had a chance to test that configuration? > > Robert N M Watson My rationale was that bootp_nfsroot() is undefined when BOOTP_NFSROOT is configured and must result in a build failure. As BOOTP_NFSROOT is not defined for GENERIC, the change doesn't affect the GENERIC build. I've PXE booted a generic (albiet RELENG_5) kernel that includes the change and observed no differences. -- Brian Somers <brian@Awfulhak.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org>