From owner-svn-src-stable-10@freebsd.org Mon Dec 18 23:04:24 2017 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB786E905D8; Mon, 18 Dec 2017 23:04:24 +0000 (UTC) (envelope-from grog@lemis.com) Received: from www.lemis.com (www.lemis.com [208.86.226.86]) by mx1.freebsd.org (Postfix) with ESMTP id 5AD5B75BFE; Mon, 18 Dec 2017 23:04:24 +0000 (UTC) (envelope-from grog@lemis.com) Received: from eureka.lemis.com (lemis.com [192.109.197.81]) by www.lemis.com (Postfix) with ESMTP id 75DEB1B72806; Mon, 18 Dec 2017 23:04:22 +0000 (UTC) Received: by eureka.lemis.com (Postfix, from userid 1004) id 2907F4494B1; Tue, 19 Dec 2017 10:04:21 +1100 (AEDT) Date: Tue, 19 Dec 2017 10:04:21 +1100 From: Greg 'groggy' Lehey To: Baptiste Daroussin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r326923 - stable/10/usr.bin/calendar/calendars Message-ID: <20171218230421.GE4376@eureka.lemis.com> References: <201712172212.vBHMCwYH026523@repo.freebsd.org> <20171218142306.zy46plfrctwhrcwg@ivaldir.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ns7jmDPpOpCD+GE/" Content-Disposition: inline In-Reply-To: <20171218142306.zy46plfrctwhrcwg@ivaldir.net> Organization: The FreeBSD Project Phone: +61-3-5346-1370, +61-3-5309-0418 Mobile: 0401 265 606. Use only as instructed. WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 23:04:24 -0000 --Ns7jmDPpOpCD+GE/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 18 December 2017 at 15:23:06 +0100, Baptiste Daroussin wrote: > On Sun, Dec 17, 2017 at 10:12:58PM +0000, Greg Lehey wrote: >> Author: grog >> Date: Sun Dec 17 22:12:57 2017 >> New Revision: 326923 >> URL: https://svnweb.freebsd.org/changeset/base/326923 >> >> Log: >> Correct character set. > > You are "correcting" a UTF-8 character into a ISO-8859 character directly in > branch 10. > > This looks wrong in multiple way: > 1. everything was converted into UTF-8 in 2011 on purpose For small values of "everything", maybe. I've checked three files: calendar.history, fr_FR.ISO8859-1/calendar.fetes and de_DE.ISO8859-1/calendar.geschichte. Only the first was in UTF-8. It sounds like a good idea to convert the files to UTF-8, but it has to be done to all of them. And how about adding some information about the preferred character set? We could kill two birds with one stone and add this to the top of each file: /* -*- coding: utf-8 -*- That would clarify things and also tell Emacs the character encoding automatically. Even for non-Emacs users it would be an advantage. > 2. why directly to the 10 branch and no in head? Finger trouble. Mea culpa. I'll back it out when we come to an agreement on how to do the rest. Greg -- Sent from my desktop computer. Finger grog@FreeBSD.org for PGP public key. See complete headers for address and phone numbers. This message is digitally signed. If your Microsoft mail program reports problems, please read http://lemis.com/broken-MUA --Ns7jmDPpOpCD+GE/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlo4SXUACgkQIubykFB6QiPs3gCgkKWTTZPNknnSn1rQPTunXGgs kfYAnRgr7YnEhSIjyJMTgUa/YoHgdcc+ =PchE -----END PGP SIGNATURE----- --Ns7jmDPpOpCD+GE/--