From owner-cvs-all Fri May 17 3:41:33 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 7F71237B404; Fri, 17 May 2002 03:41:22 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4HAfLva009325; Fri, 17 May 2002 11:41:21 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.3/8.12.3) with ESMTP id g4HAfGWs090869; Fri, 17 May 2002 11:41:16 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200205171041.g4HAfGWs090869@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Mike Barcroft Cc: "J. Mallett" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/usr.bin/tee tee.c In-Reply-To: Message from Mike Barcroft of "Thu, 16 May 2002 23:11:07 EDT." <20020516231106.G66219@espresso.q9media.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 17 May 2002 11:41:16 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > J. Mallett writes: > > jmallett 2002/05/16 19:28:47 PDT > > > > Modified files: > > usr.bin/tee tee.c > > Log: > > Remove spurious casts in malloc(3)'s argument. > > Okay. > > > Use `return' instead of `exit' at the bottom of main(). > > This part is wrong. The usual style for BSD software is to identify > exit points with explicit exit() calls. I think this has been discussed a number of times on the lists. No decision was made either way. style(9) says nothing about it. Personally I prefer return because of the C++ implications, but that's a weak argument. I suspect the sysinstall crunch stuff prefers return too (but that's a guess). So the ``wrongness'' was in changing exit to return, not the use of either. It's up to the individual which they use, but people shouldn't change from one to the other without a good reason. > > Revision Changes Path > > 1.7 +3 -3 src/usr.bin/tee/tee.c > > Best regards, > Mike Barcroft -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message