From owner-svn-src-head@FreeBSD.ORG Thu Jun 5 13:11:50 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D219EA5; Thu, 5 Jun 2014 13:11:50 +0000 (UTC) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "alchemy.franken.de", Issuer "alchemy.franken.de" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 200992AF8; Thu, 5 Jun 2014 13:11:49 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.8/8.14.8/ALCHEMY.FRANKEN.DE) with ESMTP id s55DBdXA053296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jun 2014 15:11:39 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.8/8.14.8/Submit) id s55DBdav053295; Thu, 5 Jun 2014 15:11:39 +0200 (CEST) (envelope-from marius) Date: Thu, 5 Jun 2014 15:11:38 +0200 From: Marius Strobl To: Warner Losh Subject: Re: svn commit: r263749 - in head: . sys/amd64/conf sys/conf sys/i386/conf sys/sparc64/conf Message-ID: <20140605131138.GG679@alchemy.franken.de> References: <201403252208.s2PM8VXj019660@svn.freebsd.org> <201404071505.09468.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (alchemy.franken.de [0.0.0.0]); Thu, 05 Jun 2014 15:11:39 +0200 (CEST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh , John Baldwin X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2014 13:11:50 -0000 On Mon, Apr 07, 2014 at 03:12:34PM -0600, Warner Losh wrote: > > On Apr 7, 2014, at 1:05 PM, John Baldwin wrote: > > > On Tuesday, March 25, 2014 6:08:31 pm Warner Losh wrote: > >> Author: imp > >> Date: Tue Mar 25 22:08:31 2014 > >> New Revision: 263749 > >> URL: http://svnweb.freebsd.org/changeset/base/263749 > >> > >> Log: > >> Rather than require a makeoptions DEBUG to get debug correct, > >> add it in kern.mk, but only if we're using clang. While this > >> ... > >> Modified: head/sys/amd64/conf/GENERIC > >> ============================================================================== > >> --- head/sys/amd64/conf/GENERIC Tue Mar 25 21:57:50 2014 (r263748) > >> +++ head/sys/amd64/conf/GENERIC Tue Mar 25 22:08:31 2014 (r263749) > >> @@ -21,7 +21,7 @@ > >> cpu HAMMER > >> ident GENERIC > >> > >> -makeoptions DEBUG=-gdwarf-2 # Build kernel with gdb(1) debug symbols > >> +makeoptions DEBUG=-g > >> makeoptions WITH_CTF=1 # Run ctfconvert(1) for DTrace support > > > > Did you mean to lose this comment in all these files? > > No. I didn?t mean to loose it. Damn. Thanks! FYI, restoring these comments and then MFCing the whole thing - which would be great to have in 9.3-RELEASE - is still missing. Marius