From owner-freebsd-ports  Sun Dec 21 23:10:04 1997
Return-Path: <owner-freebsd-ports>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id XAA03958
          for ports-outgoing; Sun, 21 Dec 1997 23:10:04 -0800 (PST)
          (envelope-from owner-freebsd-ports)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id XAA03950;
          Sun, 21 Dec 1997 23:10:02 -0800 (PST)
          (envelope-from gnats)
Resent-Date: Sun, 21 Dec 1997 23:10:02 -0800 (PST)
Resent-Message-Id: <199712220710.XAA03950@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-ports
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, frankch@waru.life.nthu.edu.tw
Received: from waru.life.nthu.edu.tw (root@waru.life.nthu.edu.tw [140.114.98.13])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA03651
          for <FreeBSD-gnats-submit@freebsd.org>; Sun, 21 Dec 1997 23:01:18 -0800 (PST)
          (envelope-from frankch@waru.life.nthu.edu.tw)
Received: (from frankch@localhost)
	by waru.life.nthu.edu.tw (8.8.8/8.8.7) id OAA15266;
	Mon, 22 Dec 1997 14:45:29 +0800 (CST)
Message-Id: <199712220645.OAA15266@waru.life.nthu.edu.tw>
Date: Mon, 22 Dec 1997 14:45:29 +0800 (CST)
From: frankch@waru.life.nthu.edu.tw
Reply-To: frankch@waru.life.nthu.edu.tw
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: ports/5361: Correct patch for biology/babel
Sender: owner-freebsd-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         5361
>Category:       ports
>Synopsis:       patch-ab eliminate gets warning but breaks menu function
>Confidential:   yes
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-ports
>State:          open
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Dec 21 23:10:01 PST 1997
>Last-Modified:
>Originator:     Frank Chen Hsiung Chan
>Organization:
Department of Life Science, National Tsing Hua University, Hsinchu, Taiwan
>Release:        FreeBSD 2.2.5-STABLE i386
>Environment:

	
        FreeBSD 2.2.5 STABLE

>Description:

	
	The patch file patch-ab replace gets() with fgets() to eliminate
	run time warning regarding unsafe gets(). Yet the patch break menu
	functionality of babel.
	Thanks Tony Maher <tonym@angis.usyd.edu.au> for pointing me to
	this.

>How-To-Repeat:

	

>Fix:
	
	
	The following patch modify patches/patch-ab so that babel can working
	under menu mode.
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx cut here xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
diff -ruN babel.orig/patches/patch-ab babel/patches/patch-ab
--- babel.orig/patches/patch-ab	Mon Dec 22 14:25:15 1997
+++ babel/patches/patch-ab	Mon Dec 22 14:29:49 1997
@@ -1,5 +1,5 @@
---- menus.c.orig	Thu Dec  4 20:20:28 1997
-+++ menus.c	Thu Dec  4 20:21:46 1997
+--- menus.c.orig	Tue Jan 21 23:52:36 1997
++++ menus.c	Mon Dec 22 14:29:37 1997
 @@ -63,9 +63,9 @@
      }
    }
@@ -26,12 +26,14 @@
      if (strlen(OutputKeywords) < 1)
        strcpy(OutputKeywords,"KEYWORDS GO HERE");
    }
-@@ -167,7 +167,7 @@
+@@ -167,8 +167,8 @@
    while (done == FALSE)
    {
      printf("Choice : ");
 -    gets(choice_string);
+-    for (i = 0; i < (int) strlen(choice_string); i++)
 +    fgets(choice_string, 99, stdin);
-     for (i = 0; i < (int) strlen(choice_string); i++)
++    for (i = 0; i < ((int) strlen(choice_string) - 1) ; i++)
      {
        if (!isdigit(choice_string[i]))
+ 	choice = 0;
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx cut here xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

>Audit-Trail:
>Unformatted: