From owner-svn-ports-head@FreeBSD.ORG Tue Sep 3 11:38:22 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6511E43B; Tue, 3 Sep 2013 11:38:22 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 201AB2D57; Tue, 3 Sep 2013 11:38:21 +0000 (UTC) Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 1986C20743; Tue, 3 Sep 2013 07:38:13 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute6.internal (MEProxy); Tue, 03 Sep 2013 07:38:13 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:from:to:cc:mime-version :content-transfer-encoding:content-type:in-reply-to:references :subject:date; s=smtpout; bh=TP7kTOYp8AgOUOTZdhx2dcr6bv4=; b=HlR JNpvCS4vqUDRAnt6egYgComv2MW8aclgu8LhLVgF7EkWBCp4pU8F7hSGB+UaUXGR CUvwlb8aZfCPJNM7PqXhKZcvJywHh+3/xSeYoaUiLyB3nFs3qvdDG5qVDdh2DvO6 s2soPyy7eUHvYx2R66KY3BIQmScW2gz7DelSJKic= Received: by web3.nyi.mail.srv.osa (Postfix, from userid 99) id E6728B00074; Tue, 3 Sep 2013 07:38:12 -0400 (EDT) Message-Id: <1378208292.31958.17293657.7A5FBE25@webmail.messagingengine.com> X-Sasl-Enc: j9E9SgJb2umTm1hHBd4QE/hXhHHenJt23YSzgiO2IpdI 1378208292 From: Mark Felder To: Alexey Dokuchaev MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-ed2f0e98 In-Reply-To: <20130902014108.GE43972@FreeBSD.org> References: <201309011728.r81HSx4Z057688@svn.freebsd.org> <20130902014108.GE43972@FreeBSD.org> Subject: Re: svn commit: r325891 - in head/dns/rbldnsd: . files Date: Tue, 03 Sep 2013 06:38:12 -0500 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 11:38:22 -0000 On Sun, Sep 1, 2013, at 20:41, Alexey Dokuchaev wrote: > On Sun, Sep 01, 2013 at 05:28:59PM +0000, Mark Felder wrote: > > New Revision: 325891 > > URL: http://svnweb.freebsd.org/changeset/ports/325891 > > > > @@ -37,6 +23,8 @@ GROUPS= ${USERS} > > PKGMESSAGE= ${WRKDIR}/pkg-message > > SUB_FILES= pkg-message > > > > +.include > > + > > Any reason not to use instead? > I have no idea. I've never seen any documentation explaining the intricacies of bsd.port.options.mk and bsd.port.mk vs bsd.port.pre/post.mk. If it works, I just run with it. > > do-install: > > @if [ ! -d ${ROOTDIR} ]; then \ > > ${MKDIR} ${ROOTDIR}; \ > > @@ -47,7 +35,7 @@ do-install: > > ${FILESDIR}/example ${PREFIX}/etc/rbldnsd/ > > @${INSTALL_PROGRAM} ${WRKSRC}/rbldnsd ${PREFIX}/sbin/ > > @${INSTALL_MAN} ${WRKSRC}/rbldnsd.8 ${PREFIX}/man/man8/ > > The whole do-install recipe is badly indented (extra tabstop); > destination > paths carry bogus slashes at EOL, manpages should be installed relative > to > MAN[n]PREFIX (where optional n is section number). > > > -.if !defined(NOPORTDOCS) > > +.if ${PORT_OPTIONS:MDOCS} > > @${MKDIR} ${DOCSDIR}/ > > @${INSTALL_DATA} ${WRKSRC}/CHANGES-0.81 ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/TODO ${DOCSDIR} > > @@ -57,7 +45,6 @@ do-install: > > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.default ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.init ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/rbldnsd.spec ${DOCSDIR} > > - @${INSTALL_DATA} ${DISTDIR}/rbldnsd.html ${DOCSDIR} > > We do not mute installation commands (muting MKDIR is fine). Silent > build > log does help to debug any potential problems. > Another three items that portlint should be picking up > > .endif > > > > -.include > > +.include > > Using above would have allow you to avoid changing > this line. > > > --- head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:00 2013 (r325890) > > +++ head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:59 2013 (r325891) > > @@ -8,6 +8,5 @@ etc/rbldnsd/example > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.default > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.init > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.spec > > -%%PORTDOCS%%%%DOCSDIR%%/rbldnsd.html > > %%PORTDOCS%%@dirrm %%DOCSDIR%% > > @dirrmtry etc/rbldnsd/ > > Superfluous slash at EOL. > And a fourth. Where do I file bug reports against portlint? This was a simple maintainer update. I run this software in production at work, so I know the port is fully functional as-is. These changes are all style except possibly the bsd.*.mk stuff you've suggested. If we're going to clean up the entire ports tree we either need better tools to detect some of these issues or we need to start throwing errors when things aren't perfect. And thanks for pointing these things out -- I just simply took the maintainer's patch, applied, and fixed the messy rc script. It passed rclint/portlint, redports, and I was able to upgrade our production rbldnsd servers, so I didn't scrutinize the port further.