From owner-freebsd-bugs@FreeBSD.ORG Wed Jun 26 22:50:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id ACAC7876 for ; Wed, 26 Jun 2013 22:50:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 798B711BF for ; Wed, 26 Jun 2013 22:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5QMo0as037577 for ; Wed, 26 Jun 2013 22:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5QMo0VK037576; Wed, 26 Jun 2013 22:50:00 GMT (envelope-from gnats) Resent-Date: Wed, 26 Jun 2013 22:50:00 GMT Resent-Message-Id: <201306262250.r5QMo0VK037576@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Olivier Cochard-Labbé Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A8E67602 for ; Wed, 26 Jun 2013 22:44:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id 9B47B1170 for ; Wed, 26 Jun 2013 22:44:08 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5QMi8wH002128 for ; Wed, 26 Jun 2013 22:44:08 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5QMi8nK002127; Wed, 26 Jun 2013 22:44:08 GMT (envelope-from nobody) Message-Id: <201306262244.r5QMi8nK002127@oldred.freebsd.org> Date: Wed, 26 Jun 2013 22:44:08 GMT From: Olivier Cochard-Labbé To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: bin/180014: Patch for kldstat: add quiet option to filename mode X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2013 22:50:00 -0000 >Number: 180014 >Category: bin >Synopsis: Patch for kldstat: add quiet option to filename mode >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 26 22:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Olivier Cochard-Labbé >Release: current >Organization: BSD Router Project >Environment: FreeBSD orange.bsdrp.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r252056M: Fri Jun 21 17:24:08 CEST 2013 root@orange.bsdrp.net:/usr/obj/usr/local/BSDRP/BSDRPcur/FreeBSD/src/sys/PROD amd64 >Description: kldstat have a quiet (-q) option, but it's supported only for modulname (-m) and not for filename (-n). This patch add quiet option for filename too. >How-To-Repeat: >Fix: Patch attached with submission follows: --- kldstat.c.orig 2013-06-27 00:19:44.339868707 +0200 +++ kldstat.c 2013-06-27 00:34:52.730802738 +0200 @@ -78,7 +78,7 @@ static void usage(void) { - fprintf(stderr, "usage: kldstat [-v] [-i id] [-n filename]\n"); + fprintf(stderr, "usage: kldstat [-q] [-v] [-i id] [-n filename]\n"); fprintf(stderr, " kldstat [-q] [-m modname]\n"); exit(1); } @@ -146,8 +146,13 @@ } if (filename != NULL) { - if ((fileid = kldfind(filename)) < 0) - err(1, "can't find file %s", filename); + if ((fileid = kldfind(filename)) < 0) { + if (!quiet) + err(1, "can't find file %s", filename); + return 1; + } else if (quiet) { + return 0; + } } printf("Id Refs Address%*c Size Name\n", POINTER_WIDTH - 7, ' '); >Release-Note: >Audit-Trail: >Unformatted: