Date: Thu, 18 Sep 2014 23:28:52 -0500 From: Pedro Giffuni <pfg@freebsd.org> To: Kevin Lo <kevlo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r271792 - head/include Message-ID: <D4390EAA-6D32-4AAC-B6CF-1E247FF545E9@freebsd.org> In-Reply-To: <20140919015228.GA12490@ns.kevlo.org> References: <201409181718.s8IHIhNL052969@svn.freebsd.org> <20140919015228.GA12490@ns.kevlo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Il giorno 18/set/2014, alle ore 20:52, Kevin Lo <kevlo@FreeBSD.org> ha = scritto: > On Thu, Sep 18, 2014 at 05:18:43PM +0000, Pedro F. Giffuni wrote: >>=20 >> Author: pfg >> Date: Thu Sep 18 17:18:42 2014 >> New Revision: 271792 >> URL: http://svnweb.freebsd.org/changeset/base/271792 >>=20 >> Log: >> unistd: move setpgrp(2) to the __BSD_VISIBLE section >>=20 >> Our setpgrp(2) differs from the specified by POSIX, which >> only has one argument, and is only meant for compatibility >> with BSD. >>=20 >> Reference: >> = http://pubs.opengroup.org/onlinepubs/009695399/functions/setpgrp.html >>=20 >> Pointed-out in: openbsd-tech (2014-09-16) >> MFC after: 6 weeks >>=20 >> Modified: >> head/include/unistd.h >>=20 >> Modified: head/include/unistd.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/include/unistd.h Thu Sep 18 17:15:38 2014 = (r271791) >> +++ head/include/unistd.h Thu Sep 18 17:18:42 2014 = (r271792) >> @@ -453,7 +453,6 @@ int encrypt(char *, int); >> long gethostid(void); >> int lockf(int, int, off_t); >> int nice(int); >> -int setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */ >> int setregid(gid_t, gid_t); >> int setreuid(uid_t, uid_t); >>=20 >> @@ -567,6 +566,7 @@ int setkey(const char *); >> int setlogin(const char *); >> int setloginclass(const char *); >> void *setmode(const char *); >> +int setpgrp(pid_t _pid, pid_t _pgrp); /* obsoleted by setpgid() */ >> void setproctitle(const char *_fmt, ...) __printf0like(1, 2); >> int setresgid(gid_t, gid_t, gid_t); >> int setresuid(uid_t, uid_t, uid_t); >=20 > Since there are no prototypes in unistd.h include arguments,=20 > I'd be inclined to drop them for consistency. >=20 The effect on ports would have to be evaluated first, but TBH I don=92t = find having this extra function around for a while troublesome at all. FWIW, strtoq and strtouq, in stdlib.h, are more =93interesting=94. =20 Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4390EAA-6D32-4AAC-B6CF-1E247FF545E9>