Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Apr 2013 15:16:23 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        FreeBSD Current <freebsd-current@freebsd.org>, "O. Hartmann" <ohartman@zedat.fu-berlin.de>, FreeBSD ports <freebsd-ports@freebsd.org>, Jan Beich <jbeich@tormail.org>
Subject:   Re: CURRENT (r249438): (devel/libiconv)./unistd.h:686:5: error: invalid token at start of a preprocessor expression : #if @GNULIB_EUIDACCESS@
Message-ID:  <516EF507.6040309@FreeBSD.org>
In-Reply-To: <FC566DC6-486C-4741-8491-BEAB2BAAF4CA@FreeBSD.org>
References:  <1365877246.2093.20.camel@thor.walstatt.dyndns.org> <1URs5b-000B9U-A2@internal.tormail.org> <E15F2208-0A57-4C40-B7B0-FEA7953500AD@FreeBSD.org> <1USKxR-00025i-Tt@internal.tormail.org> <FC566DC6-486C-4741-8491-BEAB2BAAF4CA@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-04-17 06:07:47 -0400, Dimitry Andric wrote:
> On Apr 17, 2013, at 07:31, Jan Beich <jbeich@tormail.org> wrote:
>> Dimitry Andric <dim@FreeBSD.org> writes: On Apr 16, 2013, at
>> 00:42, Jan Beich <jbeich@tormail.org> wrote:
> ...
>>>> Maybe -O3 overoptimizes regex in libc e.g.,
>>>> 
>>>> $ echo '#if @GNULIB_EUIDACCESS@' | sed
>>>> 's/@GNULIB_EUIDACCESS@/0/' #if @GNULIB_EUIDACCESS@
>>>> 
>>>> $ echo 'aaaaaaaaaaaaaaaaxxxaaaa' | sed
>>>> 's/aaaaaaaaaaaaxxxaaaa//' aaaaaaaaaaaaaaaaxxxaaaa
>>> 
>>> How did you arrive at this result?
>> 
>> 1/ chroot into poudriere jail for /head amd64 2/ echo CFLAGS+=-O3
>> >> /etc/make.conf 3/ make -j2 (in /usr/src/lib/libc) 4/ prepend
>> LD_LIBRARY_PATH=. before sed(1) 5/ rebuild regcomp.o, regcomp.So
>> with -O2 to confirm
> 
> I have been able to reproduce this on amd64, with -O3, but not on
> i386. It seems regcomp() is either miscompiled at -O3, or it
> contains some bug triggered only by the vectorizer.  I am still
> investigating.
...

With "-fno-vectorize", this problem doesn't seem to happen.

FYI,

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iQEcBAEBAgAGBQJRbvUHAAoJECXpabHZMqHOekEIAIml2te9436LzTFsr794y82E
Vmytl95H+vW9Nj0qK5X/DkB/0MSepL5FZqKF5CSNTXFoNJoVFewYRIH/H5oICSpZ
jfS4evF9i2mEDOScTyC/XaucvcVWupLE9Kf7FHEk5YIhDMs4r4nzwMFGkzffEqPK
yLkV/Cpc8xjvi28OuXd1KaPIcX3S8Z9vEmWPyljtseRv9WlC5gT44fSz18hmqYmv
fWSiML4YKKkDRAPOCy/Shpf5QUcygOul7Jz8RiDBx3O4R5goGW8Ee8Napn7UulSL
nAXTHy8dcSbiAqqPKeXhmZGPCotj++P9s3jEvunOxL7lvrdjfy3WtGedcp02ia8=
=jwYS
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?516EF507.6040309>