From owner-cvs-all@FreeBSD.ORG Fri Aug 18 15:42:47 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D90BE16A4DA; Fri, 18 Aug 2006 15:42:47 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2444543D4C; Fri, 18 Aug 2006 15:42:47 +0000 (GMT) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net ([12.207.12.9]) by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP id <20060818154246m92002rmhde>; Fri, 18 Aug 2006 15:42:46 +0000 Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.6/8.13.6) with ESMTP id k7IFggA0003075; Fri, 18 Aug 2006 10:42:42 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.6/8.13.6/Submit) id k7IFgeN6003074; Fri, 18 Aug 2006 10:42:40 -0500 (CDT) (envelope-from brooks) Date: Fri, 18 Aug 2006 10:42:40 -0500 From: Brooks Davis To: Yar Tikhiy Message-ID: <20060818154240.GA3050@lor.one-eyed-alien.net> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no> <20060818143310.GA14203@comp.chem.msu.su> <20060818143508.GA2545@lor.one-eyed-alien.net> <20060818153744.GA14726@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20060818153744.GA14726@comp.chem.msu.su> User-Agent: Mutt/1.5.11 Cc: Brooks Davis , Dag-Erling Sm?rgrav , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Aug 2006 15:42:48 -0000 --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 18, 2006 at 07:37:44PM +0400, Yar Tikhiy wrote: > On Fri, Aug 18, 2006 at 09:35:08AM -0500, Brooks Davis wrote: > > On Fri, Aug 18, 2006 at 06:33:11PM +0400, Yar Tikhiy wrote: > > > On Fri, Aug 18, 2006 at 04:13:37PM +0200, Dag-Erling Sm?rgrav wrote: > > > > Yar Tikhiy writes: > > > > > Log: > > > > > The ps(1) command is unfriendly to scripts by default because > > > > > it limits the width of its output to the value of $COLUMNS, or > > > > > what TIOCGWINSZ reports, or 79 columns. We should specify -ww > > > > > to ps(1) so that it removes the limit and prints lines in full. > > > > > Otherwise very long command pathnames could be mishandled, e.g., > > > > > by _find_processes(). > > > >=20 > > > > or perhaps _find_processes() should use pgrep(1) instead of ps(1). > > >=20 > > > I considered that but had to stick to ps(1) because pgrep was in > > > /usr/bin while ps was in /bin. The use of /usr/bin tools should > > > be very limited in rc.subr(8). OTOH, pgrep uses /lib libs only, > > > which makes it possible to transfer pgrep+pkill to /bin if we can > > > stand the growth of / by some 50 kbytes. > >=20 > > I think that's appropriate since pgrep is such an obvious fit for this > > sort of thing. I think we'll want to consider compatability symlinks > > due to existing hardcoded paths in scripts. >=20 > Creating the compat symlinks should be as easy as adding the following > lines to the Makefile: >=20 > SYMLINKS=3D ${BINDIR}/pgrep /usr/bin/pgrep > SYMLINKS+=3D ${BINDIR}/pkill /usr/bin/pkill >=20 > Hopefully they can be removed after a certain period of time. >=20 > Should we just override BINDIR in the Makefile and let the things > settle before requesting the repo-copy? That's probably the best way to go. Then we get any screaming out of the way before the repo surgury happens. :) -- Brooks --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE5d/vXY6L6fI4GtQRAkzqAJsG0sliz3BkYKJKLQ12FDbhpSYz2wCeKOyz aULv+zUaIS/koAjrkcPeZFo= =5SNt -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--