From owner-svn-src-all@FreeBSD.ORG Sun Sep 8 07:22:09 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5391174 for ; Sun, 8 Sep 2013 07:22:09 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BA0712E9F for ; Sun, 8 Sep 2013 07:22:08 +0000 (UTC) Received: (qmail 59868 invoked from network); 8 Sep 2013 08:01:59 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 8 Sep 2013 08:01:59 -0000 Message-ID: <522C2593.9080001@freebsd.org> Date: Sun, 08 Sep 2013 09:21:55 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Mikolaj Golub Subject: Re: svn commit: r254773 - head/sys/net References: <201308241117.r7OBHPQ1032341@svn.freebsd.org> <20130907153029.GB7349@gmail.com> In-Reply-To: <20130907153029.GB7349@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, zec@freebsd.org, bz@freebsd.org, svn-src-head@freebsd.org, julian@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Sep 2013 07:22:09 -0000 On 07.09.2013 17:30, Mikolaj Golub wrote: > Hi, > > On Sat, Aug 24, 2013 at 11:17:25AM +0000, Andre Oppermann wrote: >> Author: andre >> Date: Sat Aug 24 11:17:25 2013 >> New Revision: 254773 >> URL: http://svnweb.freebsd.org/changeset/base/254773 >> >> Log: >> Resolve the confusion between the head_list and the hook list. >> >> The linked list of pfil hooks is changed to "chain" and this term >> is applied consistently. The head_list remains with "list" term. >> >> Add KASSERT to vnet_pfil_uninit(). > > ... > >> vnet_pfil_uninit(const void *unused) >> { >> >> - /* XXX should panic if list is not empty */ >> + KASSERT(LIST_EMPTY(&V_pfil_head_list), >> + ("%s: pfil_head_list %p not empty", __func__, &V_pfil_head_list)); >> PFIL_LOCK_DESTROY_REAL(&V_pfil_lock); >> return (0); >> } >> > > It is triggered when destroying a vnet, due to inet/inet6 pfil hooks > are not being unregistered. > > The attached patch fixes the issue for me. I am going to commit it if > there are no objections -- might the unregistration has been skipped > intentionally due to some unresolved issue? There's no reason that I know of. And if there were then unregistering would be unsafe in any case. -- Andre