Date: Tue, 2 Sep 2014 06:50:05 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r366841 - head/lang/tcl86/files Message-ID: <20140902065005.GC94467@ptrcrt.ch> In-Reply-To: <54048A3B.4030001@marino.st> References: <201409010731.s817Vrxf062753@svn.freebsd.org> <20140901074609.GA32100@FreeBSD.org> <65B530D9-4740-4A60-A2F5-40335A520C4E@adamw.org> <54048A3B.4030001@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--tsOsTdHNUZQcU9Ye Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014-Sep-01, 17:01, John Marino wrote: > On 9/1/2014 16:47, Adam Weinberger wrote: > > On 1 Sep, 2014, at 3:46, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > >> Since when did we abandon the practice of doing 'svn diff' before > >> commit? > >=20 > > Alexey, please direct your frustration elsewhere. Pietro fixed > > (hopefully) a problem that caused a lot of tcl-dependent ports to > > break. He should be commended, not sneered at. If you don=E2=80=99t lik= e the > > way makepatch works, take it up with portmgr, not with the committers > > who use it. I know for a fact that portmgr is interested in extending > > makepatch to DTRT. > >=20 > > Besides, there are simply situations where makepatch is just not the > > tool to use. Sometimes I *have* to run diff(1) by hand. Sometimes I > > need to run "make patch=E2=80=9D before I can edit the diff. Sometimes = I=E2=80=99ve > > edited multiple files and I want to test one diff at a time. > > Sometimes a file needs to be touched by two different patches (I > > don=E2=80=99t like it, but ten years ago it seems like people really di= d). >=20 >=20 > While I also pushed back against danfe@ on this post, it's obvious that > makepatch was used. The commit didn't do anything except change the > timestamp. I'm sorry to contradict the obvious, but I've never ever used makepatch in my life. I didn't even know it existed before danfe@'s email. I always generated my patch with diff -uN. Moreover, the commit clearly *did* do things other than change the timestamp. https://svnweb.freebsd.org/ports/head/lang/tcl86/files/patch-unix-Makefile.= in?r1=3D366841&r2=3D366840 --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --tsOsTdHNUZQcU9Ye Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJUBWidXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgiex3UP/0BFbOrggaEx5wTUlGN4F/wv aFJMVypmqZjgiXY/Yw+tsgGw7/EAXhUMbS5/5YcVgDMo1U1MOgGlF+bZUmiGT9kA p3Cmij8wZyv6avCwq2seJKpzPFHl4Z+GNnI3NqjEbxqXfzEGWGBZx61SXfhDXDFp Sns6xI/fDxjdtPV5YNnVv7iwOGXqL3cR1HRA+VwXcSmSBMXmT0dLF0jR1XqGtsZU yZjkYbIPyrYyy9UT06Gs59Tz0A/l6KVefY68T269zH4/6fvgNkg6zIWzu7K5aAsM xO0gscNQdsF8yni974AB8r+90xRBN+Dn+vQELFIH0IzCa6YbG+KdWlRB661yBnDw sThtIJuvLUyiJAqfdr60r7zySNHMmieKo1z42US1G8VKVYW2LBlosyXZLaVjaVUa lAbRKLbCaNyup6cCsZHsJAOKABDJToAzwufSYB09bljZZqY6kUW5SBlCs3fLOpUR klopLC6ipCqh1yfWAD84Xk+Kvvx0p8qYo+MY3llK1YLkZkbaNqGz1Z3QyEeB8E3J Jj6tDlqlzOB38DHj0TVA372ab32RY3Ig462/2MkrVpBEoG29bzAbgobnFwsowptm 4lNPWxyHgXfYtn4D80QjUsEgiWnPlCkKT9U1xvbSHsgwgJKyQM+AhyM0sYxVe0Ql iGj8gNA6RbNZdqRzGvKR =+emA -----END PGP SIGNATURE----- --tsOsTdHNUZQcU9Ye--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140902065005.GC94467>