From owner-svn-src-all@freebsd.org Thu Sep 1 04:55:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AEF2BBCB173; Thu, 1 Sep 2016 04:55:55 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-yb0-f172.google.com (mail-yb0-f172.google.com [209.85.213.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74D96EC2; Thu, 1 Sep 2016 04:55:54 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-yb0-f172.google.com with SMTP id d205so1873132ybh.0; Wed, 31 Aug 2016 21:55:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CG9KLSVpTH9IjfRbtly59EMeLC8QjVjEPVfb2j+vZLU=; b=czs+NqzTVyJcRcVUjNgsKdyrCY9VeqXryo1UhgkjxNdIE/DmC6YpbGmP1EVaHFHg6L /9KuVrEvAVhpT3hBdxeDDz5bDUK3yMyh6G+WiQHUVu3NRFFWSlXGRKrWJp+elBmZYYGJ 6fIuQDUHRWr67dqMd1UYY7JaoMG2JS3lNXlaBkD1gtlbP0sy49fdQAUwTmhj1W2OvGWt 4x5xEpjkgk/V9WostF4VMRLweg4u0AuoBn+Bf2SIlub21WC+/2JN3DpVED9kVAGqG1fb IsTT3x+XIQFzrXeLxDOugIDyq6acVOpxuwrOXS1TxCswkMV/iEDGncaJZYY9+waI/KJR tJqQ== X-Gm-Message-State: AE9vXwNXqy385JHqFkUoF164JlALuHhilQNYVXkUcBasAjDcJa7GswrJMyAO5UbrfZicQA== X-Received: by 10.37.123.195 with SMTP id w186mr9934798ybc.186.1472679067564; Wed, 31 Aug 2016 14:31:07 -0700 (PDT) Received: from mail-yb0-f178.google.com (mail-yb0-f178.google.com. [209.85.213.178]) by smtp.gmail.com with ESMTPSA id e197sm651679ywa.16.2016.08.31.14.31.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Aug 2016 14:31:07 -0700 (PDT) Received: by mail-yb0-f178.google.com with SMTP id h3so21896085ybi.2; Wed, 31 Aug 2016 14:31:07 -0700 (PDT) X-Received: by 10.37.25.4 with SMTP id 4mr9680559ybz.161.1472679067216; Wed, 31 Aug 2016 14:31:07 -0700 (PDT) MIME-Version: 1.0 References: <201608200008.u7K08Bok069627@repo.freebsd.org> <8A65E29F-1DF1-44F4-9E38-FFC038EE52E7@FreeBSD.org> In-Reply-To: <8A65E29F-1DF1-44F4-9E38-FFC038EE52E7@FreeBSD.org> From: Eric Joyner Date: Wed, 31 Aug 2016 21:30:56 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r304510 - head/sys/dev/ixl To: Dimitry Andric , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 04:55:55 -0000 It's weird that the gcc message is mentioning "ixlv_media_change", but I'll do something about it shortly. On Wed, Aug 31, 2016 at 2:16 PM Dimitry Andric wrote: > On 31 Aug 2016, at 18:53, Ed Maste wrote: > > > > On 19 August 2016 at 20:08, Eric Joyner wrote: > >> Author: erj > >> Date: Sat Aug 20 00:08:10 2016 > >> New Revision: 304510 > >> URL: https://svnweb.freebsd.org/changeset/base/304510 > >> > >> Log: > >> ixlv(4): Fix ixlv(4) not loading when loaded as a kernel module and > netmap is enabled. > > > > I did not confirm it's this commit, but kernel builds currently have > > this warning: > > > > if_ixlv.o: warning: common of `ixl_crcstrip' overridden by definition > > if_ixl.o: warning: defined here > > if_ixlv.o: warning: multiple common of `ixl_rx_miss' > > if_ixl.o: warning: previous common is here > > if_ixlv.o: warning: multiple common of `ixl_rx_miss_bufs' > > if_ixl.o: warning: previous common is here > > Interestingly, with the external gcc build, it is even an error: > > --- kernel.full --- > linking kernel.full > if_ixlv.o:(.bss+0x0): multiple definition of `ixl_crcstrip' > if_ixl.o:(.data+0xb8): first defined here > if_ixlv.o: In function `ixlv_media_change': > /builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixlv.c:2252: multiple > definition of `ixl_rx_miss_bufs' > if_ixl.o:/builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixl.c:680: first > defined here > if_ixlv.o: In function `ixlv_media_change': > /builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixlv.c:2262: multiple > definition of `ixl_rx_miss' > if_ixl.o:/builds/FreeBSD_HEAD_amd64_gcc/sys/dev/ixl/if_ixl.c:681: first > defined here > *** [kernel.full] Error code 1 > > See e.g. > https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc/1505/console > > -Dimitry > >