From owner-freebsd-current@FreeBSD.ORG Wed Jul 28 13:18:55 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2F4C106564A for ; Wed, 28 Jul 2010 13:18:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 3F8EF8FC1E for ; Wed, 28 Jul 2010 13:18:54 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o6SDIp7m087027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Jul 2010 16:18:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o6SDIpUR073512; Wed, 28 Jul 2010 16:18:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o6SDIppS073462; Wed, 28 Jul 2010 16:18:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 28 Jul 2010 16:18:51 +0300 From: Kostik Belousov To: Andriy Gapon Message-ID: <20100728131851.GU22295@deviant.kiev.zoral.com.ua> References: <20100726132451.GA18443@mech-cluster241.men.bris.ac.uk> <1280226205.78791.0.camel@buffy.york.ac.uk> <20100727115831.GA46325@mech-cluster241.men.bris.ac.uk> <1280238737.78791.20.camel@buffy.york.ac.uk> <20100727144703.GA46905@mech-cluster241.men.bris.ac.uk> <1280249605.78791.36.camel@buffy.york.ac.uk> <4C502D22.10800@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y51z1SGMnxVzkhDv" Content-Disposition: inline In-Reply-To: <4C502D22.10800@icyb.net.ua> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Gavin Atkinson , freebsd-current@freebsd.org Subject: Re: free(sc, M_DEVBUF) [Was: amd64 panic snd_hda - hdac_get_capabilities: Invalid corb size (0)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2010 13:18:55 -0000 --Y51z1SGMnxVzkhDv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2010 at 04:14:10PM +0300, Andriy Gapon wrote: > on 27/07/2010 19:53 Gavin Atkinson said the following: > >=20 > > Thanks. Can you try > > http://people.freebsd.org/~gavin/mexas-hda-panic.diff > >=20 > > and see if that solves things for you? > >=20 > > (Credit goes to avg@ for looking into this before me :) >=20 > BTW, it seems that there is an epidemic of "free(sc, M_DEVBUF)" in sound = drivers. > And not only them, but I haven't looked at the other cases - perhaps the = code > there does something different and thus correct. >=20 >=20 > glimpse -w M_DEVBUF | fgrep -w free | fgrep '(sc,' > /usr/src/sys/dev/sound/pci/hda/hdac.c: free(sc, M_DEVBUF); > /usr/src/sys/net/if_lagg.c: free(sc, M_DEVBUF); > /usr/src/sys/net/if_lagg.c: free(sc, M_DEVBUF= ); > /usr/src/sys/net/if_lagg.c: free(sc, M_DEVBUF); > /usr/src/sys/net/if_bridge.c: free(sc, M_DEVBUF); > /usr/src/sys/net/if_bridge.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/ich.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/ich.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/maestro3.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/maestro3.c: free(sc, M_DEVBUF); > /usr/src/sys/net/if_enc.c: free(sc, M_DEVBUF); > /usr/src/sys/sun4v/sun4v/simdisk.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/ofw/ofw_disk.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/isa/ess.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/sbus/cs4231.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/atiixp.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/emu10kx-pcm.c: free(sc, M_DEVBUF= ); > /usr/src/sys/dev/sound/pci/emu10kx-pcm.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/emu10kx-pcm.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/ds1.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/ds1.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/cmi.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/cmi.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/neomagic.c: free(sc, = M_DEVBUF); > /usr/src/sys/dev/sound/pci/neomagic.c: free(sc, M_DEVBUF= ); > /usr/src/sys/dev/sound/pci/neomagic.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/neomagic.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/solo.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/als4000.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/als4000.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/vibes.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/emu10k1.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/emu10k1.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/cs4281.c: free(sc, M_DEVBUF); > /usr/src/sys/dev/sound/pci/cs4281.c: free(sc, M_DEVBUF); >=20 >=20 > Good example of how get examples get multiplied. >=20 > P.S. > Actually all non-sound case seem to be correct, explicitly malloc-ed memo= ry gets > freed. If anybody goes to make infrastructure work on the sound drivers, it might be not that bad idea to replace clone.c with cdevpriv. --Y51z1SGMnxVzkhDv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxQLjoACgkQC3+MBN1Mb4hN2QCffq1CgP2Iqu8pTLbq3qoRfxkB Tk0AoJImzG2/dN+Pz+pQmcwf4VhkrUb+ =D+b1 -----END PGP SIGNATURE----- --Y51z1SGMnxVzkhDv--