From owner-cvs-all@FreeBSD.ORG  Sun Jul  8 23:55:47 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1055816A469
	for <cvs-all@FreeBSD.org>; Sun,  8 Jul 2007 23:55:47 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with SMTP id 936CC13C455
	for <cvs-all@FreeBSD.org>; Sun,  8 Jul 2007 23:55:46 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 21902 invoked by uid 399); 8 Jul 2007 23:55:46 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 8 Jul 2007 23:55:46 -0000
X-Originating-IP: 127.0.0.1
Message-ID: <46917980.5080105@FreeBSD.org>
Date: Sun, 08 Jul 2007 16:55:44 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.4 (X11/20070617)
MIME-Version: 1.0
To: Edward Tomasz Napierala <trasz@FreeBSD.org>
References: <200707081232.l68CWDqv084906@repoman.freebsd.org>
In-Reply-To: <200707081232.l68CWDqv084906@repoman.freebsd.org>
X-Enigmail-Version: 0.95.1
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Martin Wilke <miwi@FreeBSD.org>, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio/oss Makefile ports/audio/oss/files
 oss.in pkg-message.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jul 2007 23:55:47 -0000

Edward Tomasz Napierala wrote:
> trasz       2007-07-08 12:32:13 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     audio/oss            Makefile 
>     audio/oss/files      oss.in pkg-message.in 
>   Log:
>   - Fix rc script to not emit a warning at startup when oss_enable is not
>     set in /etc/rc.conf,

> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/audio/oss/files/oss.in.diff?&r1=1.1&r2=1.2&f=h

You have the right idea, but the wrong fix. :) You want to use:
: ${oss_enable=NO}

and you want to do it after load_rc_config. Take a look at
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for more information.

Two other things that seem odd to me, why is there a - at the end of
the shebang line, and why does this script REQUIRE: cleanvar? I would
think that DAEMON would be a better choice, but if there is a good
reason for it to run that early, that's fine. I just want to be sure
that it's been thought through.

Thanks,

Doug

-- 

    This .signature sanitized for your protection