From owner-cvs-sys  Sun Apr  2 10:25:21 1995
Return-Path: cvs-sys-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA05369 for cvs-sys-outgoing; Sun, 2 Apr 1995 10:25:21 -0700
Received: (from ache@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id KAA05339; Sun, 2 Apr 1995 10:23:56 -0700
From: "Andrey A. Chernov" <ache>
Message-Id: <199504021723.KAA05339@freefall.cdrom.com>
Subject: Re: cvs commit: src/sys/i386/isa sio.c
To: bde@zeta.org.au (Bruce Evans)
Date: Sun, 2 Apr 1995 10:23:56 -0700 (PDT)
Cc: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com
In-Reply-To: <199504020919.TAA07274@godzilla.zeta.org.au> from "Bruce Evans" at Apr 2, 95 07:19:36 pm
X-Mailer: ELM [version 2.4 PL24]
Content-Type: text
Content-Length: 602       
Sender: cvs-sys-owner@freebsd.org
Precedence: bulk

> 
> >  Modified:    sys/i386/isa sio.c
> >  Log:
> >  Fix error:
> >  old type (stty) ioctls can easily bypass locking bits.
> >  It involves manual conversion from old ioctls to new ones,
> >  large piece of code duplicated from tty_compat.c
>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Aarggh.
> 
> There's got to be a better way to do this.  Maybe translate the locking
> bits?
> 
> Bruce
> 

Yes, but not translate locking bits, it cause even larger code.
I plan left common code into tty_compat.c and call it from sio too.
Current implementation is dirty (because of code duplication)
but 100% safe :-)