From owner-svn-ports-head@freebsd.org Wed Jun 14 09:15:23 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60090D897BC; Wed, 14 Jun 2017 09:15:23 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from smtpq2.tb.mail.iss.as9143.net (smtpq2.tb.mail.iss.as9143.net [212.54.42.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B4238053C; Wed, 14 Jun 2017 09:15:22 +0000 (UTC) (envelope-from kwm@FreeBSD.org) Received: from [212.54.42.117] (helo=lsmtp3.tb.mail.iss.as9143.net) by smtpq2.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1dL4OO-0000Yv-SL; Wed, 14 Jun 2017 11:15:12 +0200 Received: from d34030.upc-d.chello.nl ([213.46.34.30] helo=[192.168.0.51]) by lsmtp3.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1dL4OO-0007vS-O9; Wed, 14 Jun 2017 11:15:12 +0200 Message-ID: <1497431712.62091.0.camel@FreeBSD.org> Subject: Re: svn commit: r443499 - head/Mk/Uses From: Koop Mast To: Tijl Coosemans , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Date: Wed, 14 Jun 2017 11:15:12 +0200 In-Reply-To: <201706131328.v5DDSnfs097665@repo.freebsd.org> References: <201706131328.v5DDSnfs097665@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.2_0 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SourceIP: 213.46.34.30 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.2 cv=SoLg0LG0 c=1 sm=1 tr=0 a=A4srH7kgSix8FTkTlriEHg==:17 a=IkcTkHD0fZMA:10 a=LWSFodeU3zMA:10 a=6I5d2MoRAAAA:8 a=uBuKx8GwAAAA:8 a=tR9zH4XU-xYXoQnswFsA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=wZgZ3yaTFkxMEWn-yT5t:22 none X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2017 09:15:23 -0000 On Tue, 2017-06-13 at 13:28 +0000, Tijl Coosemans wrote: > Author: tijl > Date: Tue Jun 13 13:28:49 2017 > New Revision: 443499 > URL: https://svnweb.freebsd.org/changeset/ports/443499 > > Log: > Remove check for unsupported versions of FreeBSD and add some > comments. > > Submitted by: John Hein > > Modified: > head/Mk/Uses/iconv.mk > > Modified: head/Mk/Uses/iconv.mk > ===================================================================== > ========= > --- head/Mk/Uses/iconv.mk Tue Jun 13 10:44:52 2017 (r44 > 3498) > +++ head/Mk/Uses/iconv.mk Tue Jun 13 13:28:49 2017 (r44 > 3499) > @@ -41,13 +41,12 @@ ICONV_CONFIGURE_BASE= > ICONV_INCLUDE_PATH= /usr/include > ICONV_LIB_PATH= /usr/lib/libc.so > > -.if (${OPSYS} == FreeBSD && \ > - (${OSVERSION} >= 1100000 && ${OSVERSION} < 1100069)) \ > - || exists(${LOCALBASE}/include/iconv.h) > +.if exists(${LOCALBASE}/include/iconv.h) > +# Check that libiconv iconv.h is recent enough for LIBICONV_PLUG to > work. > BUILD_DEPENDS+= libiconv>=1.14_9:converters/libiconv > -ICONV_INCLUDE_PATH= ${LOCALBASE}/include > .endif > > +# LIBICONV_PLUG makes libiconv iconv.h act like libc iconv.h. > CPPFLAGS+= -DLIBICONV_PLUG > CFLAGS+= -DLIBICONV_PLUG > CXXFLAGS+= -DLIBICONV_PLUG > Hi, Was it intended to remove the OSSYS check also? That probably going to break dragonfly. -Koop