From owner-svn-ports-all@freebsd.org  Fri Sep  9 04:40:34 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49779BD1D04;
 Fri,  9 Sep 2016 04:40:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 3F7F5A88;
 Fri,  9 Sep 2016 04:40:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 3EAEE1D44; Fri,  9 Sep 2016 04:40:34 +0000 (UTC)
Date: Fri, 9 Sep 2016 04:40:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r421576 - in head/x11-wm/fluxbox: . files
Message-ID: <20160909044034.GA62060@FreeBSD.org>
References: <201609082007.u88K7Jhm001741@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201609082007.u88K7Jhm001741@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Sep 2016 04:40:34 -0000

On Thu, Sep 08, 2016 at 08:07:19PM +0000, Jason Helfman wrote:
> New Revision: 421576
> URL: https://svnweb.freebsd.org/changeset/ports/421576
> 
> [...]
> -PORTDOCS=		AUTHORS ChangeLog NEWS README TODO
> +PORTDATA=	*
> +PORTDOCS=	*
> ...
> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_active.xpm
> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_pressed.xpm
> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_close_unfocus.xpm
> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_active.xpm
> -%%DATADIR%%/styles/BlueFlux/pixmaps/button_max_pressed.xpm
> ...

Please don't do this.  We should had never allowed globbed PORTDATA (it is
less of an issue for PORTDOCS since they are usually less important and
interesting).

We have pkg-plist for a reason.  It helps to track changes, assess them
against the changelog, compare pkg-plists of different versions, etc.

Previously I could see a new theme/style files in the commit diff and
think, "hey, I should try that new version, wanna see it that theme looks
nicer than my current one".  Now it becomes harder.

./danfe