From owner-cvs-all@FreeBSD.ORG  Fri May  4 15:50:25 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 267B216A401;
	Fri,  4 May 2007 15:50:25 +0000 (UTC) (envelope-from rpaulo@fnop.net)
Received: from core.fnop.net (mx.fnop.net [82.102.11.82])
	by mx1.freebsd.org (Postfix) with ESMTP id CF00013C448;
	Fri,  4 May 2007 15:50:24 +0000 (UTC) (envelope-from rpaulo@fnop.net)
Received: from core.fnop.net (mx.fnop.net [82.102.11.82])
	by core.fnop.net (Postfix) with ESMTP id CB37D69027B;
	Fri,  4 May 2007 16:50:53 +0100 (WEST)
Received: by core.fnop.net (Postfix, from userid 1015)
	id 8C7506904C4; Fri,  4 May 2007 16:50:53 +0100 (WEST)
X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on core.fnop.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,
	FORGED_RCVD_HELO autolearn=ham version=3.1.7
Received: from epsilon.local.fnop.net (87-196-157-79.net.novis.pt
	[87.196.157.79])
	by core.fnop.net (Postfix) with ESMTP id 2A2E669027B;
	Fri,  4 May 2007 16:50:11 +0100 (WEST)
Date: Fri, 04 May 2007 16:49:35 +0100
Message-ID: <86hcqs612o.wl%rpaulo@fnop.net>
From: Rui Paulo <rpaulo@fnop.net>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200705021750.l42HoaMj067787@repoman.freebsd.org>
References: <200705021750.l42HoaMj067787@repoman.freebsd.org>
User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.3 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-Virus-Scanned: ClamAV using ClamSMTP
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/amd64/amd64 mptable_pci.c msi.c nexus.c
	src/sys/amd64/include intr_machdep.h src/sys/amd64/pci
	pci_bus.c src/sys/dev/acpica acpi_pcib_acpi.c acpi_pcib_pci.c
	src/sys/dev/pci pci.c pci_if.m pci_pci.c pci_private.h pcib_if.m ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2007 15:50:25 -0000

At Wed, 2 May 2007 17:50:36 +0000 (UTC),
John Baldwin wrote:
> 
> jhb         2007-05-02 17:50:36 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/amd64/amd64      mptable_pci.c msi.c nexus.c 
>     sys/amd64/include    intr_machdep.h 
>     sys/amd64/pci        pci_bus.c 
>     sys/dev/acpica       acpi_pcib_acpi.c acpi_pcib_pci.c 
>     sys/dev/pci          pci.c pci_if.m pci_pci.c pci_private.h 
>                          pcib_if.m pcib_private.h pcivar.h 
>     sys/i386/i386        mptable_pci.c msi.c nexus.c 
>     sys/i386/include     intr_machdep.h 
>     sys/i386/pci         pci_bus.c 
>   Log:
>   Revamp the MSI/MSI-X code a bit to achieve two main goals:
>   - Simplify the amount of work that has be done for each architecture by
>     pushing more of the truly MI code down into the PCI bus driver.
>   - Don't bind MSI-X indicies to IRQs so that we can allow a driver to map
>     multiple MSI-X messages into a single IRQ when handling a message
>     shortage.


With this change, I think, I get a WITNESS panic when booting the
second core on my MacBook

After SMP: AP #1 Launched, I get this panic:
panic: blockable sleep lock (sx) msi @ i386/i386/msi.c:374

The backtrace is:
witness_checkorder()
_sx_lock()
msi_map()
nexus_map_msi()
acpi_pcib_map_msi()
pcib_map_msi()
pci_remap_msi_irq()
msi_assign_cpu()

Any idea why?