Date: Tue, 3 Mar 2020 00:17:28 +0000 From: "glebius (Gleb Smirnoff)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing Message-ID: <5716f0c3344f106d7a0582414f0400ec@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-isgti776xdsdvju2ufh3-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-isgti776xdsdvju2ufh3-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
glebius added a comment. In D23788#523247 <https://reviews.freebsd.org/D23788#523247>, @neel_neelc.org wrote: > I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong? Well, you've added 3 new places that could return EINVAL. Could it be that one of them fires? Of course there are more places in netgraph that can return EINVAL, but first makes sense to isolate that this isn't new code. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL https://reviews.freebsd.org/D23788 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, hrs, #manpages Cc: glebius, bcr, hrs, imp, lutz_donnerhacke.de, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5716f0c3344f106d7a0582414f0400ec>