From owner-freebsd-current@FreeBSD.ORG Tue Feb 28 01:31:26 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61B3F16A423 for ; Tue, 28 Feb 2006 01:31:26 +0000 (GMT) (envelope-from pbowen@fastmail.fm) Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com [66.111.4.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5556E43D64 for ; Tue, 28 Feb 2006 01:31:13 +0000 (GMT) (envelope-from pbowen@fastmail.fm) Received: from frontend1.internal (mysql-sessions.internal [10.202.2.149]) by frontend1.messagingengine.com (Postfix) with ESMTP id DE653D38972 for ; Mon, 27 Feb 2006 20:31:11 -0500 (EST) Received: from frontend2.messagingengine.com ([10.202.2.151]) by frontend1.internal (MEProxy); Mon, 27 Feb 2006 20:31:11 -0500 X-Sasl-enc: by7idjYL32cKXrfMyY/mBFBu5RblrwuYBB9Yt5e6XUUa 1141090270 Received: from [192.168.230.123] (ip-69-33-154-226.dfw.megapath.net [69.33.154.226]) by frontend2.messagingengine.com (Postfix) with ESMTP id A13D858A0EB for ; Mon, 27 Feb 2006 20:31:09 -0500 (EST) Message-ID: <4403A7DE.60004@fastmail.fm> Date: Mon, 27 Feb 2006 19:31:10 -0600 From: Patrick Bowen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <200602211047.06599.jhb@freebsd.org> <20060222023646.GA75290@xor.obsecurity.org> <200602221101.41027.jhb@freebsd.org> In-Reply-To: <200602221101.41027.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] possible fix for the runtime going backwards warnings X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2006 01:31:26 -0000 John Baldwin wrote: >On Tuesday 21 February 2006 21:36, Kris Kennaway wrote: > > >>On Tue, Feb 21, 2006 at 10:47:04AM -0500, John Baldwin wrote: >> >> >>>The latest round of calcru() changes accidentally changed calccru() to >>>use the wrong rusage_ext structure (p->p_rux vs p->p_crux) when >>>calculating usage times for children. The patch fixes calccru() to use >>>p->p_crux again. It also moves the ruadd() in exit1() even later in the >>>function so that it takes the dying thread's last time slice into >>>account. Please test it and let me know if it makes the messages go away >>>(or if it makes things worse!) Thanks! >>> >>>http://www.FreeBSD.org/~jhb/patches/calccru.patch >>> >>> >>I think you committed this already, right? >> >> > >Yes. > > > >>I'm still getting calcru spam on the 3 SMP machines that I upgraded >>with fresh sources: >> >> > >Is it more or less than before the patch? Also, what happens if you just back >out the kern_exit.c change? > > > >> Working revision: 1.284 Wed Feb 22 00:27:32 2006 >> Repository revision: 1.284 /c/ncvs/src/sys/kern/kern_exit.c,v >> >> Working revision: 1.155 Wed Feb 22 00:27:33 2006 >> Repository revision: 1.155 /c/ncvs/src/sys/kern/kern_resource.c,v >> >>calcru: runtime went backwards from 140475 usec to 140458 usec for pid 724 >>(csh) u 9:54457/54961 s 14:86017/85496 i 0:1/1 >>calcru: runtime went backwards from 3855 usec to 3854 usec for pid 719 >>(csh) u 0:0/0 s 1:3855/3854 i 0:0/0 >>calcru: runtime went backwards from 19044 usec to 19043 usec for pid 713 >>(tcsh) u 2:8888/12695 s 1:10156/6347 i 0:0/1 >>calcru: runtime went backwards from 41540 usec to 41531 usec for pid 454 >>(nfsd) u 4:27693/27687 s 2:13846/13843 i 0:1/1 >>calcru: runtime went backwards from 4552 usec to 4551 usec for pid 452 >>(mountd) u 0:0/0 s 1:4552/4551 i 0:0/0 >>calcru: runtime went backwards from 564 usec to 563 usec for pid 140 >>(adjkerntz) u 0:0/0 s 1:564/563 i 0:0/0 >>calcru: runtime went backwards from 78654 usec to 78637 usec for pid 20 >>(swi6: task queue) u 0:0/0 s 0:0/0 i 4:78654/78637 >>calcru: runtime went backwards from 38428 usec to 38420 usec for pid 0 >>(swapper) u 0:0/0 s 11:38428/38420 i 0:0/0 >> >> >>calcru: runtime went backwards from 1496715 usec to 1496579 usec for pid 32 >>(pagezero) u 0:0/0 s 199:1496715/1496579 i 0:0/0 >>calcru: runtime went backwards from 102337 usec to 102327 usec for pid 0 >>(swapper) u 0:0/0 s 41:102337/102327 i 0:0/0 >> >> >>calcru: runtime went backwards from 1461648 usec to 1461600 usec for pid 32 >>(pagezero) u 0:0/0 s 194:1461648/1461600 i 0:0/0 >>calcru: runtime went backwards from 100852 usec to 100848 usec for pid 0 >>(swapper) u 0:0/0 s 42:100852/100848 i 0:0/0 >> >> > >The pagezero ones are truly odd. calcru() shouldn't be called for kthreads >very often (if at all). I wonder if your tickrate is changing out from under >you. Try editing sys/i386/i386/tsc.c and where it does 'set_cputicker(rdtsc, >tsc_freq, 1)' change the last parameter to '0' and see if they go away. > > > Mr. Baldwin: I installed your patch, did a "make kernel KERNCONF=GENERIC" and got fewer calcru messages (down form about 10-12 to 1-2). After changing the set_cputicker(...) parameter to "0", I got none! Copyright (c) 1992-2006 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD 7.0-CURRENT #1: Wed Feb 22 17:05:16 CST 2006 pbowen@sg1.sgc.org:/usr/obj/usr/src/sys/GENERIC WARNING: WITNESS option enabled, expect reduced performance. Timecounter "i8254" frequency 1193182 Hz quality 0 CPU: Intel Pentium III (601.37-MHz 686-class CPU) Origin = "GenuineIntel" Id = 0x68a Stepping = 10 Features=0x383f9ff Thanks, Patrick P.S. Sorry for the late reply. My SMTP server was having some problems, or something...