From owner-svn-src-all@FreeBSD.ORG  Fri Apr  2 00:14:12 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 95BD1106564A
	for <svn-src-all@freebsd.org>; Fri,  2 Apr 2010 00:14:12 +0000 (UTC)
	(envelope-from joerg@britannica.bec.de)
Received: from www.sonnenberger.org (www.sonnenberger.org [92.79.50.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 57E948FC12
	for <svn-src-all@freebsd.org>; Fri,  2 Apr 2010 00:14:12 +0000 (UTC)
Received: from britannica.bec.de (www.sonnenberger.org [192.168.1.10])
	by www.sonnenberger.org (Postfix) with ESMTP id DCDC466781
	for <svn-src-all@freebsd.org>; Fri,  2 Apr 2010 02:14:10 +0200 (CEST)
Received: by britannica.bec.de (Postfix, from userid 1000)
	id B3E5615C2B; Fri,  2 Apr 2010 02:12:31 +0200 (CEST)
Date: Fri, 2 Apr 2010 02:12:31 +0200
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: svn-src-all@freebsd.org
Message-ID: <20100402001231.GA16732@britannica.bec.de>
References: <201004011427.o31ERTaT056824@svn.freebsd.org>
	<k2m7d6fde3d1004011702ha697cd7bg96cf6bd8f58babb4@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <k2m7d6fde3d1004011702ha697cd7bg96cf6bd8f58babb4@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete
 lib version
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 00:14:12 -0000

On Thu, Apr 01, 2010 at 05:02:34PM -0700, Garrett Cooper wrote:
>     1. FILENAME_MAX could be less than PATH_MAX, and actually is on
> the BSDs (256 vs 1024). PATH_MAX allows for duplicate slashes and all
> sorts of whacky path crud and probably should be used more liberally
> in the pkg_install code. This however isn't always true in the NetBSD
> case because they're aiming for portability of pkg_install, however
> PATH_MAX is always guaranteed to be at least as large as FILENAME_MAX.

Well, I've been slowly working on eliminating the use of PATH_MAX in the
NetBSD/pkgsrc version of pkg_install. The performance gain from using
fixed stack space is minimal and the error handling generally
incompletely at best.

Joerg