From owner-freebsd-net@FreeBSD.ORG Wed Jun 4 20:45:22 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93C4F1065674 for ; Wed, 4 Jun 2008 20:45:22 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from hs-out-0708.google.com (hs-out-0708.google.com [64.233.178.245]) by mx1.freebsd.org (Postfix) with ESMTP id 443B78FC18 for ; Wed, 4 Jun 2008 20:45:22 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by hs-out-0708.google.com with SMTP id h53so201198hsh.11 for ; Wed, 04 Jun 2008 13:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=f/vHNnM2CYxdpds1lz7bCVas/hjEz8pcFPQoMedzpF8=; b=YlJrDfvxJQOAK0kZZF0N/LnAh+uDWPfiyg3NdO2tZABHx2j/2bc1J1EoWBPMMBi4LI 8AwKUMGmOP9r2jQ+yjqQEvHHP53ZcoGVWdq2pN5eGmljuyqELn4vEKEPv8mKbAUWyJyz yna/HLParHC/fZoBABsze9HujrhacflQKhhxU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=qGrIGku+mnIYYg6C37QZa2XoRw0riHijTLKHndkmsPeiNu5uH8M9pi4zbUTh4O7g6W sO4OrQzIR01QEo0EFuvGiXenqW0jO7SA8Tpdp4Ij9qmjoH/BV1xbqn9HD/rDTIGYAybM 25+pkf8ycbj/h1KxMvJW6aVu3SNEFDfn81C6w= Received: by 10.115.106.7 with SMTP id i7mr639258wam.131.1212612306952; Wed, 04 Jun 2008 13:45:06 -0700 (PDT) Received: by 10.114.174.13 with HTTP; Wed, 4 Jun 2008 13:45:06 -0700 (PDT) Message-ID: <2a41acea0806041345x435ab61cq77f59a0cc0ae043f@mail.gmail.com> Date: Wed, 4 Jun 2008 13:45:06 -0700 From: "Jack Vogel" To: "freebsd-net@freebsd.org" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Addition to the vlan driver X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jun 2008 20:45:22 -0000 I had our test group report a bug when using jumbo frames and vlans in the new igb driver. After a couple days chasing it down it turns out the issue is that the igb driver does not know when a vlan is first attached, and when you use jumbo frames you need to program a register with the maximum frame size. The test case sets the MTU first, then did the vlan setup, so the driver did not have the tag accounted for in the frame size, and thus the hardware was happily throwing frames away due to size :( Now, as a workaround I have them set up the vlan first and THEN change the MTU, but I'd rather not require that, so.... What I would like to do is add some code into the vlan_ioctl() routine that will make a call to the PARENT ioctl with SETVLAN type and an argument of the tag. By doing this both the em and igb drivers will be able to enable hardware vlan filtering as well, a feature we've never been able to use. Anyone see any issue with doing this or have any objections to it? Cheers, Jack