From owner-freebsd-commit Sun Mar 3 10:02:33 1996 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA05462 for freebsd-commit-outgoing; Sun, 3 Mar 1996 10:02:33 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id KAA05452 for cvs-all-outgoing; Sun, 3 Mar 1996 10:02:27 -0800 (PST) Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id KAA05432 Sun, 3 Mar 1996 10:02:16 -0800 (PST) Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.6.12/8.6.12) id KAA03361; Sun, 3 Mar 1996 10:02:14 -0800 From: "Rodney W. Grimes" Message-Id: <199603031802.KAA03361@GndRsh.aac.dev.com> Subject: Re: cvs commit: src/sbin/mount mount.c To: jkh@freefall.freebsd.org (Jordan K. Hubbard) Date: Sun, 3 Mar 1996 10:02:13 -0800 (PST) Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org In-Reply-To: <199603030844.AAA28759@freefall.freebsd.org> from "Jordan K. Hubbard" at Mar 3, 96 00:44:24 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-commit@FreeBSD.ORG Precedence: bulk > > jkh 96/03/03 00:44:24 > > Modified: sbin/mount mount.c > Log: > Close PR#17. This may be a contraversal fix in that now mount will > spit out two error lines for a bogus filesystem type, e.g: > > root@time-> mount -t foo /dev/sd0a /mnt > mount: exec /sbin/mount_foo for /mnt: No such file or directory > mount: exec /usr/sbin/mount_foo for /mnt: No such file or directory mount: exec mount_foo could not be found in /sbin, /usr/sbin: No such file or directory > > But I would submit that if you're even going to scan multiple directories > for a mount_foo (which I actually think is somewhat bogus - if it's not > in /sbin, you're probably in big trouble anyway), you should emit an error > for each one. I got multiple complaints (in addition to the PR) that the > existing behavior was very confusing. > > Revision Changes Path > 1.9 +1 -5 src/sbin/mount/mount.c > -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD