From owner-freebsd-ports@FreeBSD.ORG Wed Jan 21 12:19:17 2009 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 430A5106566B for ; Wed, 21 Jan 2009 12:19:17 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id E06C78FC2B for ; Wed, 21 Jan 2009 12:19:16 +0000 (UTC) (envelope-from mad@madpilot.net) Received: by megatron.madpilot.net (Postfix, from userid 1000) id B6E53130C41; Wed, 21 Jan 2009 13:19:15 +0100 (CET) Date: Wed, 21 Jan 2009 13:19:15 +0100 From: Guido Falsi To: Doug Barton Message-ID: <20090121121915.GA89663@megatron.madpilot.net> References: <49763159.2070901@parallel42.ca> <497638D3.1000908@madpilot.net> <4976BC15.3080209@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4976BC15.3080209@FreeBSD.org> X-Operating-System: FreeBSD 7.1-STABLE User-Agent: Mutt/1.5.18 (2008-05-17) Cc: ports@FreeBSD.org, Rick Chisholm Subject: Re: FreeBSD Port: squidGuard-1.4 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 12:19:17 -0000 On Tue, Jan 20, 2009 at 10:09:25PM -0800, Doug Barton wrote: > Guido Falsi wrote: > > Since ports are expected not to leave files behind when deinstalled, > > port logic checks on first install if ${DATADIR} exists. If it does it > > will NOT be created/populated and NOT included in the plist, and not > > removed on deinstall. > > > > On the contrary if it does not find such directory it will create, > > populate it remove it on deinstall. > > The way that this is traditionally handled is for the port to install > both file and file.sample, but only list file.sample in the plist. > Then at deinstall time there should be a script to compare file to > file.sample and remove file if it is the same. Repeat for values of > $file as needed. > > It is not expected or desirable for a port to remove user-modified > files (including those files created by a daemon). I agree. I was thinking if it could be acceptable to add an option to the port for installing/not installing the sample blacklists and not adding those to the plist anyway. This could be easier to handle. Perhaps also more logical. With this change a note on deinstall to check and remove by hand the folder should also be added, obviously. -- Guido Falsi