From owner-freebsd-current@FreeBSD.ORG  Sat Mar 20 16:11:42 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 45B7016A4CE
	for <current@FreeBSD.org>; Sat, 20 Mar 2004 16:11:42 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 62C0443D2D
	for <current@FreeBSD.org>; Sat, 20 Mar 2004 16:11:41 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i2L0Ba4u016699;	Sun, 21 Mar 2004 11:11:36 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i2L0BY67013192;	Sun, 21 Mar 2004 11:11:35 +1100
Date: Sun, 21 Mar 2004 11:11:33 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no>
In-Reply-To: <xzpr7vnkty0.fsf@dwp.des.no>
Message-ID: <20040321110858.Y7398@gamplex.bde.org>
References: <xzpr7vnkty0.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: current@FreeBSD.org
Subject: Re: Giant not owned in gbincore()
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Mar 2004 00:11:42 -0000

On Sat, 20 Mar 2004, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> running America's Army 2.0.0a under ktrace results in the following
> panic:
> ...
> exit1+0x47a
> 0xc04920a6 is in exit1 (/usr/src/sys/kern/kern_exit.c:371).
> 366=09=09tracecred =3D p->p_tracecred;
> 367=09=09p->p_tracecred =3D NULL;
> 368=09=09mtx_unlock(&ktrace_mtx);
> 369=09=09PROC_UNLOCK(p);
> 370=09=09if (tracevp !=3D NULL)
> 371=09=09=09vrele(tracevp);
> 372=09=09if (tracecred !=3D NULL)
> 373=09=09=09crfree(tracecred);
> 374=09#endif

The above is not current.  This was fixed in:

% RCS file: /home/ncvs/src/sys/kern/kern_exit.c,v
% Working file: kern_exit.c
% head: 1.228
% ...
% ----------------------------
% revision 1.228
% date: 2004/03/18 18:15:58;  author: green;  state: Exp;  lines: +4 -1
% Add the missing Giant when doing anything with VFS -- in this case,
% releasing the ktrace vnode.
% ----------------------------

Bruce