From owner-svn-src-head@freebsd.org Fri Dec 7 18:10:15 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DEB571315630 for ; Fri, 7 Dec 2018 18:10:14 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5403F70C2C for ; Fri, 7 Dec 2018 18:10:14 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1544206205; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=KkBhs7QDOMUN+K9k+hQiKbOlGj4EftqiySmg7GuZHj37LYkxbtuFdFO5VWycaOuQsmFrjpmw96NPu 0RzXK7WR9njymtJ+BJct3KIOqWLDNzfj5Ti5oxy80yffFoLCwxLtgp2KKlEBFCOih3CQ4jSylNcdPv XsJtsEE+7jnENtqK9TKdAEkDDPHuyNdJiwpg9TSZBPNimp7BrpmN9YRXL0wqUzOtL2P0TrymJupmi7 +/Mgm/+/O+AoFW6mYAmWcQ2D9RBt1n+sJMz/m9FWlZWhgOzouXZDw0U0NqAx5/rthRy+Oz3eOcvuYM bg+3YpqE6zrtNnZMx0UMbdrIcoCZIwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=jwBDMfAL3XSSyZ0SPAaMxHmScoeVh37IKwJbB7lZB50=; b=ER/jIj7mMl2ENQxeCT9RErKzWJHQCOPgV/1jCsRbAUrN3uD8coL0EfU4G55TKToRBPsqCBjtdjPMT LYiPyDCNW5D6dKPbAgHNyiq4eeflxen1dcl+4zsYqsbbCu9TMzh3X6y3vqRn0BoVtsmGY+c2OIuFqw wk9Pyw1j3gU4g/U6enMB8bs1KmGXgxOLXEwCXaxbmZ7l7++004dCJgcEKUtMlPY36MJ4RBlSC+agv6 RflAwJNZBL3JlNSQyNjAMmY9PI2MkIKRtdyG8RJ4KMdFaMwQ9ttyLKFZBmjns3NlAy2ds9pq5rpvwG PgQBMjvsQsXf3s2FkqC0QQ6HgDEGuCg== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=jwBDMfAL3XSSyZ0SPAaMxHmScoeVh37IKwJbB7lZB50=; b=sFgEXGZ/06qlH2ijNlJ5ADIB7FkSryk0b3QtZC5IgeGUNvEEnQVRvZ0S3RqRhaCHAc0VFlnkh2KF9 G0YUcwgl1qsX0MggHJZKLBc+jzyd2F9wZxfbJysGx+4jRdOteMFSMNLoLphDh/D7Zh/TtpeJF8C7eH CZvJADnjdpV/GlwSriyJzSVb7xIHM4IFvl5BH/vGTjPDnHdnHiK89uVCkzPJAj5h7E8CigPPNG0UhK n/R+GvK4r6CCk1VhheiJTSSWRNxxkl2qb4TZXMtVFnAFwXDh3M8KT1V35soFvaNwflQUGFo4ryGASA jbZldAmyzDin/R6wyK1upHZzqhfskZQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 50ff3bdb-fa4b-11e8-8a28-a1efd8da9a94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 50ff3bdb-fa4b-11e8-8a28-a1efd8da9a94; Fri, 07 Dec 2018 18:10:03 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id wB7IA1Ym064531; Fri, 7 Dec 2018 11:10:01 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1544206201.1860.288.camel@freebsd.org> Subject: Re: svn commit: r341682 - head/sys/sys From: Ian Lepore To: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 07 Dec 2018 11:10:01 -0700 In-Reply-To: <201812071205.wB7C5BvA038350@repo.freebsd.org> References: <201812071205.wB7C5BvA038350@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5403F70C2C X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:52.28.0.0/16, country:US]; NEURAL_HAM_LONG(-0.99)[-0.994,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2018 18:10:15 -0000 On Fri, 2018-12-07 at 12:05 +0000, Mateusz Guzik wrote: > Author: mjg > Date: Fri Dec  7 12:05:11 2018 > New Revision: 341682 > URL: https://svnweb.freebsd.org/changeset/base/341682 > > Log: >   unr64: use locked variant if not __LP64__ >    >   The current ifdefs are not sufficient to distinguish 32- and 64- > bit >   variants, which results e.g. in powerpc64 not using atomics. >    >   While some 32-bit archs provide 64-bit atomics, there is no huge > advantage >   of using them on these platforms. >    >   Reported by: many >   Suggested by: jhb >   Sponsored by: The FreeBSD Foundation > > Modified: >   head/sys/sys/systm.h > > Modified: head/sys/sys/systm.h > ===================================================================== > ========= > --- head/sys/sys/systm.h Fri Dec  7 12:02:31 2018 (r341 > 681) > +++ head/sys/sys/systm.h Fri Dec  7 12:05:11 2018 (r341 > 682) > @@ -523,7 +523,7 @@ int alloc_unr_specific(struct unrhdr *uh, u_int > item); >  int alloc_unrl(struct unrhdr *uh); >  void free_unr(struct unrhdr *uh, u_int item); >   > -#if defined(__mips__) || defined(__powerpc__) > +#ifndef __LP64__ >  #define UNR64_LOCKED >  #endif >   > This seems like a wholly unsatisfying solution compared to how trivial it would be to do something like have each arch's atomic.h set a symbol to indicate whether 64-bit atomics are available. Dismissing 32-bit arches because you don't perceive performance to be important there doesn't seem like a valid argument. -- Ian