From owner-freebsd-current@freebsd.org Thu Nov 7 15:37:59 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CEC121B7DCB for ; Thu, 7 Nov 2019 15:37:59 +0000 (UTC) (envelope-from phil@juniper.net) Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4786x320N5z3Lv9; Thu, 7 Nov 2019 15:37:58 +0000 (UTC) (envelope-from phil@juniper.net) Received: from pps.filterd (m0108158.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA7FbUJr032571; Thu, 7 Nov 2019 07:37:46 -0800 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2051.outbound.protection.outlook.com [104.47.36.51]) by mx0a-00273201.pphosted.com with ESMTP id 2w41vb231g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 07 Nov 2019 07:37:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KR7+02xf89iZp84tNn3k1EsXFJ4EgdHAT9Vj04sZQOjhnKKGs4nrRBne1DiR1fdX/C5yDj8fJscbe0gg0GKwXud5rGj22DxWBBR4ZE/iLPHh+8+hxE2eFDsfYr3V7GHJxW4uTrL3rGdVXADniTXygu8kIbYasRpoOfP3yf7yWT5NTVoFeb8E1/gyH81YAgekPl4K8I+8ZFZ3mw0Mx3XRWv6IL0gBP4V1lSmcBbDuOSb/tMadcXWjNv8Di29xyDvsqNFQ1eZErw1duGMbdYBhtbzwTA7Q9jb95KjV49/V7yS1HQt4kqN9X+cbiuhG5Gn+4PLL5giQquGWzkng8uijwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H5Z8759owhHyKHASBlLXtkOmFP6Z8YrVt+BAK08Jcys=; b=QLe+SbS0xs9N8b0XhMWdeFHEAfSRfXM/jPmeb3Oq6I9ov/IGwe6wPErpehq6sLoqSQkfArqpUNBYRZJC/iOqk6m8fWKq7reFcELdFWRuOxy/pYxv2F+q0XHaO2O1ZUVzDMdmDBq5rB6IWHcrnvG2LYvk22yjxTlPtU6dW/9K9+wpQ21jUB5Tw8XIvrrhUMibhIuepwqxVp31eWmax7EIGosXgL7A6CE52oU/nngSHiTbHXMbpwjFnzKK1qtAnHidgzO0WBDLx1t39qRbROHR/MdE1WMUjzUBc2jVtTiq0sdJ5S9+cZoi/6m2rPkzREAfJfD8rkFnzHz/DwstZeVfZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.13) smtp.rcpttodomain=stacktic.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none Received: from DM5PR05CA0010.namprd05.prod.outlook.com (2603:10b6:3:d4::20) by BL0PR05MB5474.namprd05.prod.outlook.com (2603:10b6:208:65::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.16; Thu, 7 Nov 2019 15:37:41 +0000 Received: from CO1NAM05FT056.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by DM5PR05CA0010.outlook.office365.com (2603:10b6:3:d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.16 via Frontend Transport; Thu, 7 Nov 2019 15:37:41 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.13 as permitted sender) Received: from P-EXFEND-EQX-02.jnpr.net (66.129.239.13) by CO1NAM05FT056.mail.protection.outlook.com (10.152.96.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2451.15 via Frontend Transport; Thu, 7 Nov 2019 15:37:41 +0000 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXFEND-EQX-02.jnpr.net (10.104.8.55) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 7 Nov 2019 07:37:40 -0800 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 7 Nov 2019 07:37:40 -0800 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 7 Nov 2019 07:37:40 -0800 Received: from idle.juniper.net (idleski.juniper.net [172.25.5.10]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id xA7Fbbvt012578; Thu, 7 Nov 2019 07:37:39 -0800 (envelope-from phil@juniper.net) Received: from [10.0.0.3] (localhost [127.0.0.1]) by idle.juniper.net (8.15.2/8.15.2) with ESMTP id xA7FYjYX080710; Thu, 7 Nov 2019 10:34:45 -0500 (EST) (envelope-from phil@juniper.net) From: Phil Shafer To: Arnaud Ysmal CC: , , Subject: Re: Segmentation fault in netstat after r354373 -> r354373 update Date: Thu, 7 Nov 2019 10:40:04 -0500 X-Mailer: MailMate (1.13r5655) Message-ID: <155BBBD2-C93F-4C01-A329-7EC195091574@juniper.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.13; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(39860400002)(396003)(346002)(136003)(376002)(199004)(189003)(76176011)(426003)(11346002)(7126003)(336012)(446003)(2616005)(54906003)(6666004)(356004)(50466002)(86362001)(305945005)(16586007)(476003)(486006)(126002)(51416003)(26005)(53546011)(316002)(33656002)(47776003)(36756003)(5660300002)(2906002)(186003)(229853002)(76506006)(6246003)(81166006)(478600001)(81156014)(8676002)(6916009)(50226002)(8936002)(4326008)(70586007)(4744005)(70206006)(781001); DIR:OUT; SFP:1102; SCL:1; SRVR:BL0PR05MB5474; H:P-EXFEND-EQX-02.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f6802af-5e12-4308-ff0f-08d763986d0f X-MS-TrafficTypeDiagnostic: BL0PR05MB5474: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-Forefront-PRVS: 0214EB3F68 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9/FyKu67ykerFb8pTo8v2FKhJfgRW4u9oeI2tcaeSKMuZY/wF2qaIMeabY6Dm/KqvzdmQga0/qJTbWzJymNdBiXP2SZq44kE+BwTgN1wdSxRe1qZKdo7saxvsbQ2/d+2SyCNFo2BLrx9829Up8iR/4fyhvGbtibB96i9mCcSQm05aMAz17Y7erPbO5Vn8z+9IIbmWYxjBmVVaU6P0XR79OWtYJ4or9irBngcdoGXJ8p6erzPFpblliQtADklj+nctVHgFnw3PMYIG02STr9Bs4UK5gING+hcLZ3xIu5OsQ4f+0UGOfXD8Ce2zEbOJfoqeUlfXLtfhiePs1CYz3+Q84xVsk6wqGmiRAxbLDu8BcZG5mvNDtWSq7DD0kO5InWnq5LyRqRFH5JnPdVAqavTQpeZyEN1IHgSsB6vHfpjFLuYeNStgIzpV5YBlPNQgZCD X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 15:37:41.1177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f6802af-5e12-4308-ff0f-08d763986d0f X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.13]; Helo=[P-EXFEND-EQX-02.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5474 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-07_05:2019-11-07,2019-11-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 mlxscore=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 mlxlogscore=850 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911070148 X-Rspamd-Queue-Id: 4786x320N5z3Lv9 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.11 / 15.00]; RCVD_COUNT_SEVEN(0.00)[11]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017,juniper.net:s=selector1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:208.84.65.16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; IP_SCORE(-1.01)[ip: (-2.19), ipnet: 208.84.65.0/24(-1.10), asn: 26211(-1.72), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[16.65.84.208.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US]; ARC_ALLOW(-1.00)[i=1]; MID_RHS_MATCH_FROM(0.00)[] X-Mailman-Approved-At: Fri, 08 Nov 2019 02:10:00 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2019 15:37:59 -0000 +++ b/libxo/libxo.c @@ -8104,6 +8104,8 @@ xo_parse_args (int argc, char **argv) cp = strrchr(xo_program, '/'); if (cp) xo_program = ++cp; + else + cp = argv[0]; /* Reset to front of string */ /* GNU tools add an annoying ".test" as the program extension; remove it */ size_t len = strlen(xo_program); On 7 Nov 2019, at 10:08, Arnaud Ysmal wrote: > Hi, > > I just got the same issue, it happens when argv[0] does not contain a > / (calling uptime segfault but calling /usr/bin/uptime works). > > In xo_parse_args there is no check whether cp is NULL before calling > xo_streq. > > I fixed it by changing this line: > - cp = &cp[len + 1 - sizeof(gnu_ext)]; > + cp = (char *)(uintptr_t)(const char *)(&xo_program[len + 1 - > sizeof(gnu_ext)]); > > Arnaud Ysmal