From owner-svn-src-all@FreeBSD.ORG Fri Jan 22 11:44:56 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 825691065698; Fri, 22 Jan 2010 11:44:56 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 0874B8FC1F; Fri, 22 Jan 2010 11:44:55 +0000 (UTC) Received: from outgoing.leidinger.net (pD954F1B8.dip.t-dialin.net [217.84.241.184]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 449A48443D3; Fri, 22 Jan 2010 12:44:41 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id C9FE23BD48; Thu, 21 Jan 2010 08:58:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1264060733; bh=vWei0EJRQrJ1P94CpbrKX2XFXWOJC5Tb/loKlcZm2U8=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=YBWb+QavFagu+/VZ3GVITBb3juBF6YLLs3lG9vfdZR2M/OOscrFG+AaVRz3qxE3/Q a2Q/44PnYBO42GkxRcPiF2WmQy4nHY5UsZbtpNuDQPPMcAaf3VVsgWEy2XOc1LSDt3 yfZdGpis4IpNqn8Hl8MHe6K5D2WeTOXJNXoud4EqIxzqQADBmotzo9VRHCN4uCH4Nu TO/XDSkmVH0qPd7kxg0uE8C8OUSdkVqmPFJ0ibCWoS/Vj+rDuehDQLgaiQ0zAgDpYC svbS6vK2ByAqRC+WmhlVNnfc04wk/3KLEIjixC12WlVXWVi/rmjf9jPX9Mrx7HwIhC 0U0y5FVEgn0VQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o0L7wpfS021961; Thu, 21 Jan 2010 08:58:52 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Thu, 21 Jan 2010 08:58:51 +0100 Message-ID: <20100121085851.67964fn6pkgeauww@webmail.leidinger.net> Date: Thu, 21 Jan 2010 08:58:51 +0100 From: Alexander Leidinger To: "Wojciech A. Koszek" References: <201001182246.o0IMk6dw000346@svn.freebsd.org> <20100119091500.17856jhlpl7mjsow@webmail.leidinger.net> <20100121015554.GI1990@FreeBSD.org> In-Reply-To: <20100121015554.GI1990@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 449A48443D3.8C0CC X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.363, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, TW_SV 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1264765484.14179@71d+qx1gmgCNXkDuRoNZ9w X-EBL-Spam-Status: No Cc: svn-src-head@FreeBSD.org, emulation@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r202598 - head/sys/compat/linux X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2010 11:44:56 -0000 Quoting "Wojciech A. Koszek" (from Thu, 21 Jan 2010 02:55:55 +0100): > On Tue, Jan 19, 2010 at 09:15:00AM +0100, Alexander Leidinger wrote: >> Quoting "Wojciech A. Koszek" (from Mon, 18 Jan 2010 >> 22:46:06 +0000 (UTC)): >> >>> Author: wkoszek >>> Date: Mon Jan 18 22:46:06 2010 >>> New Revision: 202598 >>> URL: http://svn.freebsd.org/changeset/base/202598 >>> >>> Log: >>> Let us to use our libusb(3) in Linuxolator. >>> >>> With this change, Linux binaries can work with our libusb(3) when >>> it's compiled against our header files on GNU/Linux system -- this >>> solves the problem with differences between /dev layouts. >>> >>> With ported libusb(3), I am able to use my USB JTAG cable with Linux >>> binaries that support it. >> >> The commit log is IMHO omitting the info if you checked (or not) that there >> is no linux ioctl in this range. It would also be nice if the comment in >> linux_ioctl.h tells to check that there is no clash with a linux ioctl when >> the min/max is changed. > > Sorry for delay. > > I have tested it against ioctl() calls submitted by ported libusb(3). > Apparently, all ioctl() requests in my execution path didn't hit our > emulator, > thus I was getting warnings about unsupported ioctl(). Thus, I > reserved a range > for them. However, it looks like conflict exists with Linux *SND* stuff. > > I believe the easiest solution would be based on picking "untypable" > values for > commands: > > #define BSDEMUL_USB_REQUEST _IOWR(3, 1, struct usb_ctl_request) > > > And putting them into linux_ioctl.h just like any other ioctl(). > Simple mapping > would be provided for those calls to our native USB stack. grep(1) > says 3 or 4 > passed as a ioctl() should be fine, since none of those seem to be used in > Linux. I could bring the same macros to ported libusb(3) easily, so > that we'd > be using something that Linuxolator can finally understand in a unique way. > > Does is sound like an acceptable solution? Unfortunately I do not follow you completely... My concern is that someone maybe want to implement an ioctl which falls in the same range. As long as the ioctl is not in a range of ioctls of a normal linux kernel, it is fine for me. If in doubt, add a kernel option to either enable or disable (I'm not sure what makes more sense) the FreeBSD-usb-forward-part. Bye, Alexander. -- Once a word has been allowed to escape, it cannot be recalled. -- Quintus Horatius Flaccus (Horace) http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137