From owner-cvs-all Thu Apr 4 19:27: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 1F1BA37B41A; Thu, 4 Apr 2002 19:27:02 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA15018; Fri, 5 Apr 2002 13:27:00 +1000 Date: Fri, 5 Apr 2002 13:26:37 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: "David E. O'Brien" Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/usr.bin/yacc reader.c In-Reply-To: <200204042210.g34MAOp67222@freefall.freebsd.org> Message-ID: <20020405131509.C2961-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 4 Apr 2002, David E. O'Brien wrote: > obrien 2002/04/04 14:10:24 PST > > Modified files: > usr.bin/yacc reader.c > Log: > Revert revision 1.3. This is WARNS=4 clean w/o it and it only increases ^ one line of > the diffs to Open/NetBSD. > > Revision Changes Path > 1.15 +1 -1 src/usr.bin/yacc/reader.c This seems to reintroduce a bug. The "spacing" variable seems to be used uniinitialized to me. The changed version only compiles clean because WARNS is intentionally broken. From bsd.sys.mk: . if ${WARNS} > 1 # XXX Delete -Wuninitialized by default for now -- the compiler doesn't # XXX always get it right. CFLAGS += -Wno-uninitialized . endif Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message