From owner-svn-src-head@freebsd.org Thu Nov 30 07:03:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0115BDFAB99; Thu, 30 Nov 2017 07:03:44 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C4AB87869E; Thu, 30 Nov 2017 07:03:43 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BFB7220C8B; Thu, 30 Nov 2017 02:03:41 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Thu, 30 Nov 2017 02:03:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=N3LjB9rNng6MHNkNLcWu7N3TAy/JD aIDplBzYKdAuWI=; b=CGQLxvJR0cxBFclScL4SPpQm+FJE36ApBW3YDYaEq+6i1 P6hu6y+4DZlJ69xKwjXA4lnEZ5QcbG022WkqyAJDb6yKGBj1fDHxNyHocd+Zl3Dd EqcxcMmJW0UYOPiZbfEFMvbH+QJysImw/f90AHggheRMnrueEQdkRT9kTpFDPsyl lXDllJUifytMKSTRBwHAl9SdAiVFyb+ibw+/RS+eUEsRVfBWG9FVYLVvz55WN8ma VUlMlGgOpO6y+vwVGGWs2fabe/l7k33IwIWF49EreEsPudinveNZ4JTd2ov+ZLq7 hyEsjNm8qmkZTQ3ZXWU83UHCI+mQPwz3vQtLC8ISQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=N3LjB9 rNng6MHNkNLcWu7N3TAy/JDaIDplBzYKdAuWI=; b=UoFb1VwIf1f066N5SPXQ5P gZJWTVxtp/pNfHsiNQ4TcKdjDIClieS1vAcwDvv60u+TgM4HforLXu12qhLmrGXI zENHQuIcgHS7kVye2Q+7lTRhfwllHc56li+P+/0WG07KCFsQ9lOOab/nd+xWHuvF Il1wbiRYwosH96p3tTlrKzZmE+mQvSP4u/GHS+hRP5RACbc5KpR6V1Bqyb9JB7VD JphYBTZWgZzn5Ta5xbmOIdXqnv63jh2lvkiO2KEYKhZERerHm3d2tiYXyuVKSK6I J21BJqg05lVv7wvrjLvaQa7JLutEcYkl7B81+6xVM34UIlqT6SM8e3ekobZm6u5Q == X-ME-Sender: Received: from [192.168.0.109] (unknown [161.97.249.191]) by mail.messagingengine.com (Postfix) with ESMTPA id 2431D243F9; Thu, 30 Nov 2017 02:03:41 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\)) Subject: Re: svn commit: r326377 - in head/sys: amd64/conf arm/conf i386/conf mips/conf modules/aic7xxx/ahc modules/aic7xxx/ahd powerpc/conf sparc64/conf From: Scott Long In-Reply-To: <20171130115317.X1349@besplex.bde.org> Date: Thu, 30 Nov 2017 00:03:38 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201711292341.vATNfoSS054606@repo.freebsd.org> <20171130115317.X1349@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.3445.4.7) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 07:03:44 -0000 > On Nov 29, 2017, at 6:19 PM, Bruce Evans wrote: >=20 > On Wed, 29 Nov 2017, Scott Long wrote: >=20 >> Log: >> It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT = from >> the standard kernels. They are still available as custom compile >> options. >=20 > MI NOTES still gives MI sizes for these options. It seems unlikely > that these sizes are still correct even for 1 arch where they were = measured > on. >=20 Today, I measured a savings of ~130KiB when both options were removed. = I also did the original size measurements back in 2000-whatever. I=E2=80=99= m guessing that the difference is due to improvements in compiler technology. >> Modified: head/sys/amd64/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/amd64/conf/GENERIC Wed Nov 29 23:28:40 2017 = (r326376) >> +++ head/sys/amd64/conf/GENERIC Wed Nov 29 23:41:49 2017 = (r326377) >> @@ -123,11 +123,7 @@ device siis # = SiliconImage SiI3124/SiI3132/SiI3531 >>=20 >> # SCSI Controllers >> device ahc # AHA2940 and onboard = AIC7xxx devices >> -options AHC_REG_PRETTY_PRINT # Print register bitfields in = debug >> - # output. Adds ~128k to driver. >> device ahd # AHA39320/29320 and = onboard AIC79xx devices >> -options AHD_REG_PRETTY_PRINT # Print register bitfields in = debug >> - # output. Adds ~215k to driver. >=20 > k is a bogus unit for memory sizes. NOTES has the same bug. >=20 >> Modified: head/sys/i386/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/i386/conf/GENERIC Wed Nov 29 23:28:40 2017 = (r326376) >> +++ head/sys/i386/conf/GENERIC Wed Nov 29 23:41:49 2017 = (r326377) >> @@ -120,11 +120,6 @@ device siis # = SiliconImage SiI3124/SiI3132/SiI3531 >>=20 >> # SCSI Controllers >> device ahc # AHA2940 and onboard = AIC7xxx devices >> -options AHC_REG_PRETTY_PRINT # Print register bitfields in = debug >> - # output. Adds ~128k to driver. >> -device ahd # AHA39320/29320 and = onboard AIC79xx devices >> -options AHD_REG_PRETTY_PRINT # Print register bitfields in = debug >> - # output. Adds ~215k to driver. >> device esp # AMD Am53C974 (Tekram = DC-390(T)) >> device hptiop # Highpoint RocketRaid = 3xxx series >> device isp # Qlogic family >>=20 >=20 > This also removes ahd. This bug is only new on i386/GENERIC. Oops! > Other arches > except amd64 never had ahd. arm/conf/CRB was most broken -- it had 2 = PRETTY > options but neither ahc or ahd. Perhaps these old drivers don't = belong in > any GENERIC. There=E2=80=99s a good argument to be made for doing a house-cleaning of = GENERIC between now and when FreeBSD 12.0 is released. Scott