From owner-freebsd-bugs  Wed Feb  5 12:50:14 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id MAA10927
          for bugs-outgoing; Wed, 5 Feb 1997 12:50:14 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id MAA10921;
          Wed, 5 Feb 1997 12:50:09 -0800 (PST)
Resent-Date: Wed, 5 Feb 1997 12:50:09 -0800 (PST)
Resent-Message-Id: <199702052050.MAA10921@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, burg@is.ge.com
Received: from ns.ge.com (ns.ge.com [192.35.39.24])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA10723
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Feb 1997 12:47:02 -0800 (PST)
Received: from thomas.ge.com (thomas.ge.com [3.47.28.21]) by ns.ge.com (8.8.4/8.7.3) with ESMTP id PAA16441 for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Feb 1997 15:45:01 -0500 (EST)
Received: from vdb.is.ge.com ([3.228.100.2]) by thomas.ge.com (8.8.4/8.7.5) with ESMTP id PAA28212 for <FreeBSD-gnats-submit@freebsd.org>; Wed, 5 Feb 1997 15:47:52 -0500 (EST)
Received: (from burg@localhost) by vdb.is.ge.com (8.8.5/8.6.12) id VAA01307; Wed, 5 Feb 1997 21:43:43 +0100 (MET)
Message-Id: <199702052043.VAA01307@vdb.is.ge.com>
Date: Wed, 5 Feb 1997 21:43:43 +0100 (MET)
From: burg@is.ge.com
Reply-To: burg@is.ge.com
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/2670: fetch and proxies
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         2670
>Category:       bin
>Synopsis:       fetch fails with HTTP_PROXY
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb  5 12:50:07 PST 1997
>Last-Modified:
>Originator:     Dick van den Burg
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:
 Current as of Feb 3
 HTTP_PROXY=http-proxy.euro.ge.com:80
 netscape proxy on a BSDI system.

>Description:

 1) fetch decodes the proxy port number incorrectly resulting in 
    fetch: `http-proxy.euro.ge.com:80': invalid port number

 2) the GET has a leading / that should not be there.
    GET /http://www.xemacs.org/index.html    in stead of
    GET http://www.xemacs.org/index.html

>How-To-Repeat:


>Fix:
	
*** http.c      Wed Feb  5 21:34:32 1997
--- /usr/src/usr.bin/fetch/http.c       Fri Jan 31 20:55:50 1997
***************
*** 415,421 ****
          } while(0)
  
  retry:
!       addstr(iov, n, "GET ");
        addstr(iov, n, https->http_remote_request);
        addstr(iov, n, " HTTP/1.1\r\n");
        /*
--- 415,421 ----
          } while(0)
  
  retry:
!       addstr(iov, n, "GET /");
        addstr(iov, n, https->http_remote_request);
        addstr(iov, n, " HTTP/1.1\r\n");
        /*
*** util.c      Wed Feb  5 20:11:43 1997
--- /usr/src/usr.bin/fetch/util.c       Sun Feb  2 10:16:37 1997
***************
*** 165,171 ****
  
        colon = strchr(s, ':');
        if (colon != 0) {
!           /*          colon++; */
                errno = 0;
                ul = strtoul(colon + 1, &ep, 10);
                if (*ep != '\0' || colon[1] == '\0' || errno != 0
--- 165,171 ----
  
        colon = strchr(s, ':');
        if (colon != 0) {
!               colon++;
                errno = 0;
                ul = strtoul(colon + 1, &ep, 10);
                if (*ep != '\0' || colon[1] == '\0' || errno != 0

>Audit-Trail:
>Unformatted: