From owner-freebsd-current@freebsd.org Thu Feb 8 12:32:20 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A67DFF20648 for ; Thu, 8 Feb 2018 12:32:20 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: from mail-pg0-x22b.google.com (mail-pg0-x22b.google.com [IPv6:2607:f8b0:400e:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2A19484A94; Thu, 8 Feb 2018 12:32:20 +0000 (UTC) (envelope-from maurizio1018@gmail.com) Received: by mail-pg0-x22b.google.com with SMTP id t4so515623pgp.8; Thu, 08 Feb 2018 04:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dayRaF4YSNv7AW8Xy6d207+iupuIjD+Mdrw0UJcHsIg=; b=VYhVqFFH81wlgo0sdmzDLUK2TquE+8fwSFVBTAIUsFDfZ5b3IzZ+Lf7Yfw3WQJTciO +aTJ+hb4FwtFkYAK8fzzzksC4hhCNYQOk1O4aXQKU2JcdgoGV0scCKX1RGjYO5iPKfYl mGIAoqX6jLDEMobVGORBN6HwrpNn6lztSrmdfbfcfNTWBRmyX5FvLMzbGG8NMKJlijE4 G/6n6nIdkFUSN3UupcIUOYViueZYYSeEuLR4KK66BF3iblr2D0bQO0BwT3CJXXQ8DUR5 IThV8l+PGwywnvvYByiPW2YsThPjm4vJ7f7lLSJL8VQbGmdxqKbG1AX1TAr9jt8Ghjv2 vRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dayRaF4YSNv7AW8Xy6d207+iupuIjD+Mdrw0UJcHsIg=; b=mmepGm3AKIdfinya4j6zugwePw5of2Ec5gkztlLFAP+y3c9+vfgqH16rXkKrPp3oR7 fl7ECcrJ6f+D23fa3KcKU1DzzIg4GYc5rHyma7AhQeZk8lbA3sgo1sWWdBEbT2VPyc7U Y13+QXLVxv1wPWwAN6mrKNm4lFpnYuVZjKfL9JMTg309Uj0DQsgnHEN1fCFbve6XxFof yTb3zRx+pwx+ZrEFIr2VhSNiaO0BXYCJiO3e8U5r26lrlqyPCN5XpVh0iHH+w4+oTzHx 6rCD8b0cg9X/B7TJoOSkGA1PWH6318rnNR8JqDMSv0mspY1B9+IF0Xo8gA3s2kPD499h W4nw== X-Gm-Message-State: APf1xPA0zyKBT2OLTirp1Z6gqywi5Hafuku1L0oQJ3hKurQHKDFCd3LH K7+cU74nYzEQE1JDeGSWFSLZyts1ocvId95krFBHWA== X-Google-Smtp-Source: AH8x227bPpFlf7hHZKkptF91MfiI/oVVNPem75EVaFcRHz/gZp60gj64eXG15oP76hX/b0GneTbq5VVhAV3PEweL+D8= X-Received: by 10.98.72.18 with SMTP id v18mr524142pfa.107.1518093139220; Thu, 08 Feb 2018 04:32:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.138.144 with HTTP; Thu, 8 Feb 2018 04:32:18 -0800 (PST) In-Reply-To: <7D39479C-85AB-45B2-BF39-0566AC073C5A@jnielsen.net> References: <3E242843-7D43-4A36-A448-E4B0DACB2AB4@jnielsen.net> <5EDB0747-41DE-4ECF-925E-EF24FAA550F3@jnielsen.net> <1517943001.1366.100.camel@freebsd.org> <1C97132B-099B-4BAA-9C39-A1BE00481CAC@jnielsen.net> <7D39479C-85AB-45B2-BF39-0566AC073C5A@jnielsen.net> From: Maurizio Vairani Date: Thu, 8 Feb 2018 13:32:18 +0100 Message-ID: Subject: Re: Fatal trap 12 booting FreeBSD-CURRENT via isboot kernel module. To: John Nielsen Cc: freebsd-current , Daisuke Aoyama , Ian Lepore Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 12:32:20 -0000 2018-02-07 19:29 GMT+01:00 John Nielsen : > > On Feb 7, 2018, at 6:07 AM, Maurizio Vairani > wrote: > > > > 2018-02-06 23:02 GMT+01:00 John Nielsen : > > > On Feb 6, 2018, at 11:50 AM, Ian Lepore wrote: > > > > > > On Tue, 2018-02-06 at 11:33 -0700, John Nielsen wrote: > > >> > > >> Apparently sending a NULL socket pointer to ifioctl hasn't worked > > >> since this commit in 2011: > > >> https://svnweb.freebsd.org/base?view=revision&revision=218757 > > >> > > >> So I'm going to add this patch to the port unconditionally once it > > >> works. > > >> > > >> Unfortunately, I can't compile the port with either my patch below or > > >> your original replacement version of isboot_ifup(). :( Did you make > > >> other changes? Here's the error I'm getting: > > >> > > >> --- isboot.o --- > > >> isboot.c:425:53: error: incomplete definition of type 'struct thread' > > >> error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td); > > >> ~~^ > > >> /usr/src/sys/sys/systm.h:185:8: note: forward declaration of 'struct > > >> thread' > > >> struct thread; > > >> ^ > > >> 1 error generated. > > >> > > > > > > Try adding #include if it's not already in the list. It > > > may be that that file got included via pollution from some other header > > > file in the past and maybe now that has changed. > > > > > > If you're already including sys/proc.h then I'm clueless. > > > > Thanks Ian, that appears to work. > > > > Maurizio, can you apply the attached patch to a clean ports tree and see > if isboot-kmod will build and function properly for you? This is all the > changes from this thread and the previous one. If you let me know it works > I'll get the port updated. > > > > > > Hi John, I need some help. > > > > I am running: > > # uname -a > > FreeBSD 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r328383: Thu Jan 25 > 04:48:52 UTC 2018 root@releng3.nyi.freebsd.org:/ > usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 > > > > after upgrading the ports tree with: > > # portsnap fetch update > > > > I have copied the directory /usr/ports/net/isboot-kmod/ in > /root/src/isboot-kmod and /root/src/isboot-kmod.orig > > # ls -l /root/src > > total 6 > > drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod > > drwxr-xr-x 3 root wheel 6 Feb 7 13:46 isboot-kmod.orig > > -rw-rw-rw- 1 root wheel 5630 Feb 7 11:38 isboot_patch.txt > > > > Trying to apply the patch I obtain the error: > > # cd /root/src > > # patch -sC < isboot_patch.txt > > 2 out of 2 hunks failed while patching isboot-kmod/Makefile > > 5 out of 5 hunks failed while patching isboot-kmod/files/patch-isboot.c > > > > What I am missing ? > > Thanks again for your work. > > Not sure but I ran in to similar issues testing here as well. Here's the > "svn diff" patch which does work for me. Note that this one should be > applied from within the isboot-kmod directory. > > With this patch I receive this error : # pwd /root/src/isboot-kmod # patch -sC < ../isboot-kmod-0.2.13_2.diff.txt 2 out of 2 hunks failed while patching Makefile 5 out of 5 hunks failed while patching files/patch-isboot.c