From owner-freebsd-current Mon Feb 23 14:05:08 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA22828 for freebsd-current-outgoing; Mon, 23 Feb 1998 14:05:08 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from dingo.cdrom.com (dingo.cdrom.com [204.216.28.145]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA22811 for ; Mon, 23 Feb 1998 14:05:02 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (localhost [127.0.0.1]) by dingo.cdrom.com (8.8.8/8.8.5) with ESMTP id OAA12585; Mon, 23 Feb 1998 14:03:41 -0800 (PST) Message-Id: <199802232203.OAA12585@dingo.cdrom.com> X-Mailer: exmh version 2.0zeta 7/24/97 To: The Hermit Hacker cc: freebsd-current@FreeBSD.ORG Subject: Re: ATAPI related patch .. In-reply-to: Your message of "Mon, 23 Feb 1998 17:40:25 -0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 23 Feb 1998 14:03:40 -0800 From: Mike Smith Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > I recently grabbed a patch that Luigi (freebsd-multimedia) has > that is required in order to read audio tracks (using something like > tosha) from a CD...with minor modifications, I've got it in my -current > kernel and haven't noticed any problems. Thanks for the review! > I would like to commit the patch to the -current source tree, so > am asking here if there are any objections to doing this. If I hear > nothing by Wednesday (long enough?), I'll assume that it is okay and > commit it... Erk. This is thoroughly grostic. You shouldn't be doing I/O using an ioctl; this behaviour should belong on a new minor number and the raw device read handler. I would vote against the inclusion of this code, unless there is an overwhelming precedent for the technique. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message