From owner-cvs-src@FreeBSD.ORG  Thu Jun 28 20:26:25 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9566716A421;
	Thu, 28 Jun 2007 20:26:25 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 544BA13C487;
	Thu, 28 Jun 2007 20:26:25 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l5SKQ3vO047709;
	Thu, 28 Jun 2007 14:26:03 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Thu, 28 Jun 2007 14:26:40 -0600 (MDT)
Message-Id: <20070628.142640.112853202.imp@bsdimp.com>
To: rwatson@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20070628135639.Q37694@fledge.watson.org>
References: <200706281254.l5SCswtj063484@repoman.freebsd.org>
	<20070628135639.Q37694@fledge.watson.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Thu, 28 Jun 2007 14:26:04 -0600 (MDT)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netatalk aarp.h ddp.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2007 20:26:25 -0000

In message: <20070628135639.Q37694@fledge.watson.org>
            Robert Watson <rwatson@freebsd.org> writes:
: On Thu, 28 Jun 2007, Robert Watson wrote:
: 
: > rwatson     2007-06-28 12:54:58 UTC
: >
: >  FreeBSD src repository
: >
: >  Modified files:
: >    sys/netatalk         aarp.h ddp.h
: >  Log:
: >  Mark wire data structures in netatalk as __packed so that they are
: >  properly (un)padded on the arm platform.  With this change, FreeBSD/arm
: >  boxes are able to route AppleTalk properly.
: >
: >  Submitted/tested by:    Nathan Whitehorn <nathanw at uchicago dot edu>
: >  Tested on:              arm, i386, amd64
: >  Approved by:            re (kensmith)
: 
: We've now scattered __packed in a number of protocols, but I can't help but 
: wonder if we shouldn't generally be doing a sweep of callers to mtod() to find 
: all places where we cast wire data structures to C structures and checking 
: padding across platforms.  It would also be good to add more CTASSERT's about 
: wire data structure sizes beside their definitions.

More couldn't hurt...

Warner