From owner-freebsd-security  Thu Oct  8 19:45:29 1998
Return-Path: <owner-freebsd-security@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA26117
          for freebsd-security-outgoing; Thu, 8 Oct 1998 19:45:29 -0700 (PDT)
          (envelope-from owner-freebsd-security@FreeBSD.ORG)
Received: from alecto.physics.uiuc.edu (alecto.physics.uiuc.edu [130.126.8.20])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA26098
          for <freebsd-security@freebsd.org>; Thu, 8 Oct 1998 19:45:23 -0700 (PDT)
          (envelope-from igor@alecto.physics.uiuc.edu)
Received: (from igor@localhost)
	by alecto.physics.uiuc.edu (8.9.0/8.9.0) id VAA08354;
	Thu, 8 Oct 1998 21:45:13 -0500 (CDT)
From: Igor Roshchin <igor@physics.uiuc.edu>
Message-Id: <199810090245.VAA08354@alecto.physics.uiuc.edu>
Subject: Re: The necessary steps for logging (the problem is fixed) (fwd)
To: freebsd-security@FreeBSD.ORG
Date: Thu, 8 Oct 1998 21:45:13 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL43 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-security@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


Ok, 
don't crash me with your swords .. ;)

I just compiled the syslogd with the changes suggested.
THe diff file is at the bottom.
It works fine for me.
Can anybody else test it against different syslog.conf's ?

My only concern:
In line 1410 - there was a space inside ", ;"  originally:
	while (strchr(", ;", *q))

According to man syslog.conf  - I don't see why it should be there..
This is the moment when the priority is analyzed.
No spaces are allowed before the priority specification.
So, I assume, this was just a typo.
so, it should be 
	while (strchr(",;", *q))
If this is not a typo, but I just missed some meaning, please, correct me!

IgoR

=====================8< ===============================

--- syslogd.c.orig	Thu Aug  6 00:58:10 1998
+++ syslogd.c	Thu Oct  8 22:19:27 1998
@@ -1365,12 +1365,12 @@
 	}
 
 	/* scan through the list of selectors */
-	for (p = line; *p && *p != '\t';) {
+	for (p = line; *p && *p != '\t' && *p != ' ';) {
 		int pri_done;
 		int pri_cmp;
 
 		/* find the end of this facility name list */
-		for (q = p; *q && *q != '\t' && *q++ != '.'; )
+		for (q = p; *q && *q != '\t' && *q != ' ' && *q++ != '.'; )
 			continue;
 
 		/* get the priority comparison */
@@ -1402,12 +1402,12 @@
 				  ;
 
 		/* collect priority name */
-		for (bp = buf; *q && !strchr("\t,;", *q); )
+		for (bp = buf; *q && !strchr("\t,; ", *q); )
 			*bp++ = *q++;
 		*bp = '\0';
 
 		/* skip cruft */
-		while (strchr(", ;", *q))
+		while (strchr(",;", *q))
 			q++;
 
 		/* decode priority name */
@@ -1424,8 +1424,8 @@
 		}
 
 		/* scan facilities */
-		while (*p && !strchr("\t.;", *p)) {
-			for (bp = buf; *p && !strchr("\t,;.", *p); )
+		while (*p && !strchr("\t.; ", *p)) {
+			for (bp = buf; *p && !strchr("\t,;. ", *p); )
 				*bp++ = *p++;
 			*bp = '\0';
 
@@ -1454,7 +1454,7 @@
 	}
 
 	/* skip to action part */
-	while (*p == '\t')
+	while (*p == '\t' || *p == ' ')
 		p++;
 
 	switch (*p)


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message