Date: Thu, 8 May 2003 15:44:10 -0500 (CDT) From: Mark Linimon <linimon@lonesome.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/51985: [patch] bsd.port.mk: two fixes for "make maintainer" Message-ID: <200305082044.h48KiAAX033621@lonesome.lonesome.com> Resent-Message-ID: <200305082050.h48KoBX6027335@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 51985
>Category: ports
>Synopsis: [patch] bsd.port.mk: two fixes for "make maintainer"
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu May 08 13:50:11 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Mark Linimon
>Release: FreeBSD-4.7
>Organization:
FreeBSD
>Environment:
System: FreeBSD lonesome.lonesome.com 4.7-STABLE FreeBSD 4.7-STABLE #0: Fri Nov 8 23:46:29 CST 2002 root@lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA i386
>Description:
If a ports Makefile contains a bogus MAINTAINER value (i.e. one
with anthing in addition to "user@host.domain"), "make maintainer"
will fail. I want to use "make maintainer" in a project.
In addition, I don't see any reason why "make maintainer" ought
not to work in subdirectories. This patch fixes that, too.
>How-To-Repeat:
cd /usr/ports/math/vecfem;make maintainer
>Fix:
The following patch fixes both bsd.port.mk, bsd.port.subdir.mk,
and, as an extra bonus, the port that triggered the bug in
bsd.port.mk.
--- Mk/bsd.port.mk.dist Wed May 7 21:25:49 2003
+++ Mk/bsd.port.mk Thu May 8 15:06:54 2003
@@ -2067,7 +2067,7 @@
.if !target(maintainer)
maintainer:
- @${ECHO_CMD} ${MAINTAINER}
+ @${ECHO_CMD} "${MAINTAINER}"
.endif
.if !defined(CATEGORIES)
--- Mk/bsd.port.subdir.mk.dist Mon Apr 21 12:58:52 2003
+++ Mk/bsd.port.subdir.mk Thu May 8 15:20:38 2003
@@ -32,7 +32,8 @@
# clean-for-cdrom-list, clean-restricted-list,
# configure, deinstall,
# depend, depends, describe, extract, fetch, fetch-list, ignorelist,
-# install, makesum, package, readmes, realinstall, reinstall, tags
+# install, maintainer, makesum, package, readmes, realinstall, reinstall,
+# tags
#
# search:
# Search for ports using either 'make search key=<keyword>'
@@ -89,6 +90,7 @@
TARGETS+= fetch-list
TARGETS+= ignorelist
TARGETS+= makesum
+TARGETS+= maintainer
TARGETS+= package
TARGETS+= realinstall
TARGETS+= reinstall
--- math/vecfem/Makefile.dist Fri Feb 21 07:16:27 2003
+++ math/vecfem/Makefile Thu May 8 15:13:59 2003
@@ -12,7 +12,7 @@
MASTER_SITES= http://www.massey.ac.nz/~lgrosz/vecfem/downloads/
DISTNAME= vem
-MAINTAINER= Ralf Becker <ralf@akk.org>
+MAINTAINER= ralf@akk.org
COMMENT= Program to solve non-linear boundary value problems
.ifdef MPI
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305082044.h48KiAAX033621>