From owner-freebsd-ports-bugs@freebsd.org Mon Aug 1 00:38:10 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A603DBA89FB for ; Mon, 1 Aug 2016 00:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 94D721C9E for ; Mon, 1 Aug 2016 00:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u710cAuo028906 for ; Mon, 1 Aug 2016 00:38:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 211305] devel/gdb: (CORE_ADDR) 0 missing * in cast in tui/tui-stack.c Date: Mon, 01 Aug 2016 00:38:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markmi@dsl-only.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 00:38:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211305 --- Comment #7 from Mark Millard --- (In reply to Mark Millard from comment #5) The following looks to be deliberate in the code: ./nat/x86-dregs.c:209:7: warning: variable 'i' is incremented both in the l= oop header and in the loop body [-Wfor-loop-analysis] i++; ^ ./nat/x86-dregs.c:199:32: note: incremented here ALL_DEBUG_ADDRESS_REGISTERS (i) ^ >From gdb-7.11.1/gdb/nat/x86-dregs.h : /* A macro to loop over all debug address registers. */ #define ALL_DEBUG_ADDRESS_REGISTERS(i) \ for (i =3D DR_FIRSTADDR; i <=3D DR_LASTADDR; i++) >From gdb-7.11.1/gdb/nat/x86-dregs.c : ALL_DEBUG_ADDRESS_REGISTERS (i) { debug_printf ("\ \tDR%d: addr=3D0x%s, ref.count=3D%d DR%d: addr=3D0x%s, ref.count=3D%d\n", i, phex (state->dr_mirror[i], x86_get_debug_register_length ()), state->dr_ref_count[i], i + 1, phex (state->dr_mirror[i + 1], x86_get_debug_register_length ()), state->dr_ref_count[i + 1]); i++; } So an overall effect of i+=3D2 for the incrementing makes sense. It is just= not expressed very directly when ALL_DEBUG_ADDRESS_REGISTERS is used. --=20 You are receiving this mail because: You are the assignee for the bug.=