From owner-svn-src-head@freebsd.org  Mon Aug 10 22:41:50 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id C19183AFAE3;
 Mon, 10 Aug 2020 22:41:50 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BQWDG4XDjz4sBS;
 Mon, 10 Aug 2020 22:41:50 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net
 [98.207.126.143])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 (Authenticated sender: rpokala)
 by smtp.freebsd.org (Postfix) with ESMTPSA id F1B4F18530;
 Mon, 10 Aug 2020 22:41:49 +0000 (UTC)
 (envelope-from rpokala@freebsd.org)
User-Agent: Microsoft-MacOutlook/16.39.20071300
Date: Mon, 10 Aug 2020 15:41:44 -0700
Subject: Re: svn commit: r364071 - head/sys/kern
From: Ravi Pokala <rpokala@freebsd.org>
To: Mateusz Guzik <mjg@FreeBSD.org>, <src-committers@freebsd.org>,
 <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Message-ID: <B1DCE6F5-7B6E-45A1-8A43-11E04A37145A@panasas.com>
Thread-Topic: svn commit: r364071 - head/sys/kern
References: <202008101040.07AAeEtt096924@repo.freebsd.org>
In-Reply-To: <202008101040.07AAeEtt096924@repo.freebsd.org>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2020 22:41:50 -0000

-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Mateusz Guzik <mjg@FreeBSD.org>
Date: 2020-08-10, Monday at 03:40
To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: svn commit: r364071 - head/sys/kern

    Author: mjg
    Date: Mon Aug 10 10:40:14 2020
    New Revision: 364071
    URL: https://svnweb.freebsd.org/changeset/base/364071

    Log:
      cache: strlcpy -> memcpy

But why?

-Ravi (rpokala@)

    Modified:
      head/sys/kern/vfs_cache.c

    Modified: head/sys/kern/vfs_cache.c
    ==============================================================================
    --- head/sys/kern/vfs_cache.c	Mon Aug 10 10:37:16 2020	(r364070)
    +++ head/sys/kern/vfs_cache.c	Mon Aug 10 10:40:14 2020	(r364071)
    @@ -1934,7 +1934,8 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, 
     	}
     	len = ncp->nc_nlen = cnp->cn_namelen;
     	hash = cache_get_hash(cnp->cn_nameptr, len, dvp);
    -	strlcpy(ncp->nc_name, cnp->cn_nameptr, len + 1);
    +	memcpy(ncp->nc_name, cnp->cn_nameptr, len);
    +	ncp->nc_name[len] = '\0';
     	cache_enter_lock(&cel, dvp, vp, hash);

     	/*