From nobody Sun May 31 11:48:46 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gSwNJ1kk9z6gZ35 for ; Sun, 31 May 2026 11:48:48 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gSwNH6ZX4z3tgY for ; Sun, 31 May 2026 11:48:47 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780228127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dw/1mJcY2U0Epm6VOyOtBMd8QG58Fe6EcSomrLAxOcE=; b=OCEKDPRzpTOKizIAyA9GB/mKf9ExM1YMjDWRIybQFM2btUkIJfSsX6aJZs81WbOzqN4isC g8QJuWnWWP79PJGqewnWCs1DBNbdS1sRlYMTzd3MX6D7mCOwK6eKPZMic4HV9rq5Kqvm6Z LCpDPEDqmWfhk0nJk1kPV4Kzsuo5P91p1HCEQQkfWbtwsgQgJ1RZIDLAqKHAMk9RD1QC6A ZN9BTeZuewoS1RbSElx0avIS67Z5S6jSR7nGE9Y9c5jbib+8aQBNhX9X0mujS3SBWOuJQF BdohXqRhKlyoJeud7Qq558aCrtkvLKY/wAyvZyBphmTwlAC17g7p32lqwc1XHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780228127; a=rsa-sha256; cv=none; b=myNKndQFsJIjazyVokXMwl5NUHRkzSYXZioJPa7dy5xzDkcwlsG7yj/rPEM/BCu3usgzoU kxzAaizQwNOn4h8IOA46HOguMVp1jzqNJw1WZ76aFGUAmn8UKsHJB9qN9hiyy27BYkRnl2 DSov7ZXh0hyqvo1yr//U1macpZq3UmC0grtQkrD7SeK4Ff/dQXr+yZQyh1mbk2ifa2INqt QSZj+RDYbnr0I0epZtdnbscV0vvUdrJugVdOOqyGVHj5biVyP1xPr+UB6znmQiUZeHzhbn oUkIkwlJSrBW1/jxelvEo7utKjVxbnytfIdRBOvjfAIk+4NC2s0TslCVoaqCZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780228127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dw/1mJcY2U0Epm6VOyOtBMd8QG58Fe6EcSomrLAxOcE=; b=VzgP0pXTmo61TOm2ImxiNg2xlzkwDX3M91iea6z5ALdhiL7Nw8Eqz3yxflZgPnbJLiXFjy sDiD2044Vw6HZZui8mGH6TFwrZLwLPFmLIqFDoOG9BdkfegSvqNbvj1/c8kBT19DCUj2Wb sOlilOziosC/gG+YMdaNmIOJcNSUoZ7VVdeD8E+IEJ2ZpuhgesebRWDl/AZTvY+jyQ3lro zMdKaKp4hWww24Vh9+O23uxx7wOgL0p+nB6FquRmg38HAz/QWu2IDtN0Ki8uBC1zxRUITV nIidTw5PN1YIrMpxZLAJR22TDR4PyK7Yla34nwBdpRUTwFUYHQpEiPix1/pcyw== Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: vexeduxr) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gSwNH5VbCzngp for ; Sun, 31 May 2026 11:48:47 +0000 (UTC) (envelope-from vexeduxr@freebsd.org) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36ab8816a35so4252904a91.1 for ; Sun, 31 May 2026 04:48:47 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ9GqWIxllfjcuI3DEiQ0aWLMKrp6OfyYC2nukP4avWy+7ms/hrXzKsPm+DvQnZg7IyOPIOaSxzTJ/g+QNMUMtsQyW4cTw==@freebsd.org X-Gm-Message-State: AOJu0Yy/psKGtoIT2194g6qP87fGh97mlK3m6sl9sQZ3BSlaq8aURh7I xANVdXzWpbpKPRvx1M4VMsA4Aah/EhjnAgBQNkFK7zAv3dljwyTmqPzsD8YgT8gGMTaezwykZup GGHZlfakfn8l6YfGqMxM32U/t0OI2Kzs= X-Received: by 2002:a17:90b:1a91:b0:368:f179:ba07 with SMTP id 98e67ed59e1d1-36c4ff708d8mr6674492a91.9.1780228126593; Sun, 31 May 2026 04:48:46 -0700 (PDT) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 31 May 2026 04:48:46 -0700 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 31 May 2026 04:48:46 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> <20260530190827.15ba6ffa@thor.sb211.local> <20260531120131.387a9bb8@thor.sb211.local> In-Reply-To: <20260531120131.387a9bb8@thor.sb211.local> Date: Sun, 31 May 2026 04:48:46 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AVHnY4Ii9RI07z0toGmHUElVl5NpeKIAUGIXSLP4ftUIEFyODjMC8CnTvCx7aRA Message-ID: Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment To: A FreeBSD User Cc: Kevin Bowling , Kyle Evans , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun May 31, 2026 at 1:01 PM +0300, A FreeBSD User wrote: > Am Tage des Herren Sat, 30 May 2026 17:11:38 -0700 > Ahmad Khalifa schrieb: > >> On Sun May 31, 2026 at 1:54 AM +0300, Kevin Bowling wrote: >> > On Sat, May 30, 2026 at 2:50=E2=80=AFPM Ahmad Khalifa wrote: >> >> >> >> On Sat May 30, 2026 at 8:09 PM +0300, A FreeBSD User wrote: >> >> > Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 >> >> > Ahmad Khalifa schrieb: >> >> > >> >> >> The branch main has been updated by vexeduxr: >> >> >> >> >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D2fa4bdd7f9e99698a66= 52db405c3165fdcd41c1d >> >> >> >> >> >> commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d >> >> >> Author: Ahmad Khalifa >> >> >> AuthorDate: 2026-05-30 02:40:58 +0000 >> >> >> Commit: Ahmad Khalifa >> >> >> CommitDate: 2026-05-30 02:40:58 +0000 >> >> >> >> >> >> edk2: enable static asserts for *INT64 alignment >> >> >> >> >> >> The ia32 loader is now built with -malign-double, so these sho= uld pass. >> >> >> >> >> >> Differential Revision: https://reviews.freebsd.org/D55386 >> >> >> --- >> >> >> sys/contrib/edk2/Include/Base.h | 2 -- >> >> >> 1 file changed, 2 deletions(-) >> >> >> >> >> >> diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/In= clude/Base.h >> >> >> index 3ae798db8429..d3342c9a6ca2 100644 >> >> >> --- a/sys/contrib/edk2/Include/Base.h >> >> >> +++ b/sys/contrib/edk2/Include/Base.h >> >> >> @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) =3D=3D sizeo= f (INT16), "Alignment of >> >> >> INT16 does not STATIC_ASSERT (ALIGNOF (UINT16) =3D=3D sizeof (UIN= T16), "Alignment of >> >> >> UINT16 does not meet UEFI Specification Data Type requirements"); = STATIC_ASSERT >> >> >> (ALIGNOF (INT32) =3D=3D sizeof (INT32), "Alignment of INT32 does= not meet UEFI >> >> >> Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF (UI= NT32) =3D=3D sizeof >> >> >> (UINT32), "Alignment of UINT32 does not meet UEFI Specification Da= ta Type >> >> >> requirements"); -#ifndef _STANDALONE STATIC_ASSERT (ALIGNOF (INT64= ) =3D=3D sizeof (INT64), >> >> >> "Alignment of INT64 does not meet UEFI Specification Data Type req= uirements"); >> >> >> STATIC_ASSERT (ALIGNOF (UINT64) =3D=3D sizeof (UINT64), "Alignmen= t of UINT64 does not >> >> >> meet UEFI Specification Data Type requirements"); -#endif STATIC_A= SSERT (ALIGNOF >> >> >> (CHAR8) =3D=3D sizeof (CHAR8), "Alignment of CHAR8 does not meet= UEFI Specification Data >> >> >> Type requirements"); STATIC_ASSERT (ALIGNOF (CHAR16) =3D=3D sizeo= f (CHAR16), "Alignment >> >> >> of CHAR16 does not meet UEFI Specification Data Type requirements"= ); STATIC_ASSERT >> >> >> (ALIGNOF (INTN) =3D=3D sizeof (INTN), "Alignment of INTN does not = meet UEFI Specification >> >> >> Data Type requirements"); >> >> > >> >> > The commit seems to disturb building process and gets rogue with: >> >> > [...] >> >> > In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBa= seType.h:16: >> >> > /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static asse= rtion failed due to >> >> > requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignme= nt of INT64 does not >> >> > meet UEFI Specification Data Type requirements 844 | STATIC_ASSERT = (ALIGNOF (INT64) >> >> > =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Speci= fication Data Type >> >> > requirements"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> > /usr/src/sys/contrib/edk2/Include/Base.h:778:24: note: expanded fro= m macro 'ALIGNOF' >> >> >> >> I can't reproduce with the defaults, do you have any loader related >> >> build options changed? >> > >> > Maybe a transient stale rebuild artifact, I was able to get through it >> > with -j1 somehow. >> >> Hmm, after building this a few times I do run into a race condition >> where the interpreter isn't done building before loader_ia32.efi. Is >> that what you ran into? >> >> Looks like the SUBDIR entries need to be re-ordered, that's a different >> issue from the one above though. >> >> > >> >> Also, can you tell which target this failed on? >> >> >> >> Thanks. >> >> >> >> > >> >> > >> >> > Regards >> >> > oh >> >> >> > > Architecture is amd64. > Most prominent changes/options in /etc/src.conf amongst non-debug flags a= re in my case: > > WITH_BEARSSL=3D YES > WITHOUT_LOADER_PXEBOOT=3D YES > LOADERSIZE?=3D 555000 > WITH_BHYVE_SNAPSHOT=3D YES Ah, looks like WITH_BEARSSL triggered it. Seems like we're building the EFI bits of libsecureboot, even for the BIOS loader... I'll revert for now until I can do a deeper dive. Thanks for the report. > > I had to mess with the loadersize in the past since loader didn't build a= nymore due to some > bytes of space missing ...