Date: Sun, 3 Jun 2018 19:19:47 +0200 From: Florian Smeets <flo@smeets.xyz> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334474 - head/usr.bin/top Message-ID: <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz> In-Reply-To: <201806010551.w515pfoB090926@repo.freebsd.org> References: <201806010551.w515pfoB090926@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5OOJnSK4dcKaDFl5MFjvOoT7UHV879xib Content-Type: multipart/mixed; boundary="RKhASXiOaIqqvJvyxgaZGBxK0Jk3ykQmh"; protected-headers="v1" From: Florian Smeets <flo@smeets.xyz> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz> Subject: Re: svn commit: r334474 - head/usr.bin/top References: <201806010551.w515pfoB090926@repo.freebsd.org> In-Reply-To: <201806010551.w515pfoB090926@repo.freebsd.org> --RKhASXiOaIqqvJvyxgaZGBxK0Jk3ykQmh Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 01.06.18 07:51, Eitan Adler wrote: > Author: eadler > Date: Fri Jun 1 05:51:40 2018 > New Revision: 334474 > URL: https://svnweb.freebsd.org/changeset/base/334474 >=20 > Log: > top(1): Display of TID when using 'H' flag > =20 > Some users prefer seeing the TID when viewing individual threads. Thi= s > makes sense as the PID will be the same for multiple entries. An atte= mpt > was made to include both, but there is insufficient room. As such, us= ing > the TID. > =20 > While here, rename the header variables to be more understandable. > =20 > Discussed with: mmacy > Reported on: 2009-10-07 >=20 Hi, I think this is a mistake. The 'H' flag should keep the PID, AFAIK you cannot use the TID anywhere in top in contrast to the PID. I usually start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a process in that view, as I don't see the PID. IMHO showing TIDs should be a separate flag, 'h' maybe, as this commit changes current/expected behavior (POLA?). Also, this is not documented in the man page. Florian --RKhASXiOaIqqvJvyxgaZGBxK0Jk3ykQmh-- --5OOJnSK4dcKaDFl5MFjvOoT7UHV879xib Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7LNouHkIv7aRTXJp71uk3NWp88AFAlsUI05fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVD QjM2OEI4NzkwOEJGQjY5MTRENzI2OUVGNUJBNERDRDVBOUYzQzAACgkQ71uk3NWp 88DseQ/9FmSsirHQ4KDv9uvNpf1zXss8dzO0VRfr1BxTwEqz8ketK6vAi04olR4a TWdHZ+ril/ybAwzcuZkUY8PXdoWZQmmQyaB6L2fQkCO8GV6Br7/8zH0NI8Avxu/8 1Y0YKpKPA+YFo0Iv0aQsqY2aeL05FF9y/selp2KKoWn2jgNhz0AFDqEQtOhd1ZOt IuiY/M7qknIQs/Z3Qv8VKG1ArYS5Kd42+7uAg+C3wEDGgXxVHuz6IvBNIRSy9ItD BlP1Fwa7+PXxJNpASRDeTQMGuNnSRIagb8Z86xPJPYPxLfjgaRFfnIozQ5Dux2MD RHV/N/olZ5mIciPDcR7E0DCGgXzzPmjxcCiVUWjaUojEM+OYeJXogduKSt2F58nr JKmWlYXz4+QKb5+1rGnn/afPuZUFtPSEu4irvZ2XgE2vhiRpWj5RCuFq3sanD1mH qBMpkrhSI/3QCUWpK2KT2jSKtNJQUXpfluqnSgaDzdvR44mbO2F4z0Kt3dHkXEXT zRaZ3eboqeMiPQvBkzt15SwaQVyXpNdgS+JzkLf+IObyQmTeaO7hvlUXs68VqJD2 D3NfBiaL+lR5VE12KUcUxk6Q5Z78OoDfP3NtmrAc9aRV9PQOP11pRMZ505HhcPqy abwwAofgF9dXTDClelbvWnvYuU7xls/fgsEJLtYtXr3+pCMNCT4= =6hLe -----END PGP SIGNATURE----- --5OOJnSK4dcKaDFl5MFjvOoT7UHV879xib--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bea6b96c-d312-2c45-ccc2-f6498df5cb2c>